Re: [DISCUSS] Storing images in source repository

2019-09-17 Thread Toshihiro Suzuki
> We should not rewrite history. It will remain there but when you do shallow > clone it won't fetch this data. Our build jobs only fetch the latest 50 > commits currently. Okay. So I will just move the images to the hbase-site repository ( https://github.com/apache/hbase-site) and the README itse

Re: [DISCUSS] Storing images in source repository

2019-09-16 Thread Peter Somogyi
> I think we can do it in https://issues.apache.org/jira/browse/HBASE-22986. Sounds good! > To avoid this, I think we need to remove the images from the history of the source repository maybe by using filter-branch? We should not rewrite history. It will remain there but when you do shallow clon

Re: [DISCUSS] Storing images in source repository

2019-09-16 Thread Toshihiro Suzuki
Sounds good to me. So, should we move the images to the hbase-site repository ( https://github.com/apache/hbase-site) and move the README itself to the HBase Book? I think we can do it in https://issues.apache.org/jira/browse/HBASE-22986. > every time we pull the repository for the builds it add

Re: [DISCUSS] Storing images in source repository

2019-09-13 Thread Andrew Purtell
Sounds good to me. We have been separating out resources for site and documentation from the main repo to others for a while. Let’s continue doing that. So probably the big hbtop readme and associated resources should go into the online book and the docs in the source tree should refer to the ne

Re: [DISCUSS] Storing images in source repository

2019-09-13 Thread Sean Busbey
Sounds good to me. Maybe a comment in the hbtop readme source with a pointer about how to update the image content since folks might not know to look at hbase-site? On Fri, Sep 13, 2019, 02:27 Peter Somogyi wrote: > Hi, > > Recently the hbtop tool (HBASE-11062) was merged and it also includes a

[DISCUSS] Storing images in source repository

2019-09-13 Thread Peter Somogyi
Hi, Recently the hbtop tool (HBASE-11062) was merged and it also includes a nice README documentation with demos in GIF format. Although I think we should have more documentation like this, probably it is not a good idea to store the images in the source repository. The size of these GIF images i