Hi folks!
Given how often I see us ignoring ruby-lint feedback in precommit,
would anyone be opposed to me changing its vote from -1 to -0?
If someone eventually does the work to make it deal with e.g.
jruby-isms and maven directory structure, we could then turn it back
on. But I definitely don't
Yea, ruby lint is harsher than we need, I think. Letting it vote -0 SGTM.
On Wed, Apr 25, 2018 at 9:28 AM, Sean Busbey wrote:
> Hi folks!
>
> Given how often I see us ignoring ruby-lint feedback in precommit,
> would anyone be opposed to me changing its vote from -1 to -0?
>
> If someone eventua
Agree.
If we want to torture a contributor, we can set them on fixing all
complaints.
St.Ack
On Wed, Apr 25, 2018 at 7:28 AM, Sean Busbey wrote:
> Hi folks!
>
> Given how often I see us ignoring ruby-lint feedback in precommit,
> would anyone be opposed to me changing its vote from -1 to -0?
>
+1 for the -0 ;)
On 4/25/18 1:32 PM, Stack wrote:
Agree.
If we want to torture a contributor, we can set them on fixing all
complaints.
St.Ack
On Wed, Apr 25, 2018 at 7:28 AM, Sean Busbey wrote:
Hi folks!
Given how often I see us ignoring ruby-lint feedback in precommit,
would anyone be o
+1 to change its vote from -1 to -0. It is a little noisy now.
On 2018/04/25 14:28:24, Sean Busbey wrote:
> Hi folks!
>
> Given how often I see us ignoring ruby-lint feedback in precommit,
> would anyone be opposed to me changing its vote from -1 to -0?
>
> If someone eventually does the work
FYI, I have now updated our default yetus arguments in the precommit job so
that ruby-lint won't vote -1.
On 2018/04/25 14:28:24, Sean Busbey wrote:
> Hi folks!
>
> Given how often I see us ignoring ruby-lint feedback in precommit,
> would anyone be opposed to me changing its vote from -1 to -
