Re: [DISCUSS] shading hbase-client jackson dependency

2017-11-03 Thread Mike Drob
Ok, I was able to work around the issues that I was having downstream. We'll revisit this if it causes more problems in the future. On Thu, Nov 2, 2017 at 6:13 PM, Mike Drob wrote: > jackson-databind and anything that depends on, maybe. I think we should > figure out the situation with hbase-sha

Re: [DISCUSS] shading hbase-client jackson dependency

2017-11-02 Thread Mike Drob
jackson-databind and anything that depends on, maybe. I think we should figure out the situation with hbase-shaded-testing-util first, then I can unwind the rest of the tree. On Thu, Nov 2, 2017 at 5:46 PM, Stack wrote: > On Wed, Nov 1, 2017 at 10:58 AM, Mike Drob wrote: > > > Hi Devs, > > > >

Re: [DISCUSS] shading hbase-client jackson dependency

2017-11-02 Thread Stack
On Wed, Nov 1, 2017 at 10:58 AM, Mike Drob wrote: > Hi Devs, > > Should have thought to discuss this sooner, but I had blinders on at the > time and wasn't thinking about the bigger picture. > > Currently, hbase-client carries with it a dependency on jackson due to our > JsonMapper class, which i

Re: [DISCUSS] shading hbase-client jackson dependency

2017-11-01 Thread Mike Drob
They use our test-jar as well, so I think they will need HBASE-15666, but I haven't tried this. On Wed, Nov 1, 2017 at 2:40 PM, Sean Busbey wrote: > Can Pig work with hbase-shaded-client instead? > > On Wed, Nov 1, 2017 at 12:58 PM, Mike Drob wrote: > > Hi Devs, > > > > Should have thought to d

Re: [DISCUSS] shading hbase-client jackson dependency

2017-11-01 Thread Sean Busbey
Can Pig work with hbase-shaded-client instead? On Wed, Nov 1, 2017 at 12:58 PM, Mike Drob wrote: > Hi Devs, > > Should have thought to discuss this sooner, but I had blinders on at the > time and wasn't thinking about the bigger picture. > > Currently, hbase-client carries with it a dependency on

[DISCUSS] shading hbase-client jackson dependency

2017-11-01 Thread Mike Drob
Hi Devs, Should have thought to discuss this sooner, but I had blinders on at the time and wasn't thinking about the bigger picture. Currently, hbase-client carries with it a dependency on jackson due to our JsonMapper class, which is a very very thin wrapper around the jackson ObjectMapper. Our