Re: [NOTICE] enable error-prone checks on precommit

2018-03-10 Thread Josh Elser
Sounds beneficial to me and worth the time to run it. Thanks for the heavy lifting and the head's up! On 3/9/18 5:07 PM, Mike Drob wrote: Hi devs, Over on HBASE-20153[1] I put up a patch to include error-prone[2] compiler checks on precommit. Wanted to send out a note to the dev list to make

Re: [NOTICE] enable error-prone checks on precommit

2018-03-09 Thread Stack
Very nice Mr. Drob. S On Fri, Mar 9, 2018 at 2:07 PM, Mike Drob wrote: > Hi devs, > > Over on HBASE-20153[1] I put up a patch to include error-prone[2] compiler > checks on precommit. Wanted to send out a note to the dev list to make sure > people saw it and understood what

[NOTICE] enable error-prone checks on precommit

2018-03-09 Thread Mike Drob
Hi devs, Over on HBASE-20153[1] I put up a patch to include error-prone[2] compiler checks on precommit. Wanted to send out a note to the dev list to make sure people saw it and understood what was happening, and so there would be less surprise if things start failing. Over the past several