Zheng Hu created HBASE-22090: -------------------------------- Summary: The HFileBlock#CacheableDeserializer should pass ByteBuffAllocator to the newly created HFileBlock Key: HBASE-22090 URL: https://issues.apache.org/jira/browse/HBASE-22090 Project: HBase Issue Type: Sub-task Reporter: Zheng Hu Assignee: Zheng Hu
In HBASE-22005, we have the following TODO in HFileBlock#CacheableDeserializer: {code} public static final class BlockDeserializer implements CacheableDeserializer<Cacheable> { private BlockDeserializer() { } @Override public HFileBlock deserialize(ByteBuff buf, boolean reuse, MemoryType memType) throws IOException { // .... // TODO make the newly created HFileBlock use the off-heap allocator, Need change the // deserializer or change the deserialize interface. return new HFileBlock(newByteBuff, usesChecksum, memType, offset, nextBlockOnDiskSize, null, ByteBuffAllocator.HEAP); } {code} Should use the global ByteBuffAllocator here rather than HEAP allocator, as the TODO said, we need to adjust the interface of deserializer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)