Re: Cleanup and remove the code path where is no hbase.client.rpc.codec

2018-01-04 Thread Jerry He
On Thu, Dec 21, 2017 at 12:03 AM, Stack wrote: > On Tue, Dec 19, 2017 at 7:02 PM, Jerry He wrote: > > > RPC_CODEC_CONF_KEY 'hbase.client.rpc.codec' is a property we use on the > > client side to determine the RPC codec. > > > > It currently has a strange

Re: Cleanup and remove the code path where is no hbase.client.rpc.codec

2017-12-21 Thread Stack
On Tue, Dec 19, 2017 at 7:02 PM, Jerry He wrote: > RPC_CODEC_CONF_KEY 'hbase.client.rpc.codec' is a property we use on the > client side to determine the RPC codec. > > It currently has a strange logic. Whereas the default is KeyValueCodec, we > allow a user to specify an

Re: Cleanup and remove the code path where is no hbase.client.rpc.codec

2017-12-20 Thread Jerry He
Ok. I will open a JIRA. Thanks, Jerry On Wed, Dec 20, 2017 at 7:36 AM, Ted Yu wrote: > Jerry: > Your proposal sounds good. > > On Tue, Dec 19, 2017 at 9:55 PM, Jerry He wrote: > > > AbstractTestIPC is a good test. And it will continue to work after

Re: Cleanup and remove the code path where is no hbase.client.rpc.codec

2017-12-20 Thread Ted Yu
Jerry: Your proposal sounds good. On Tue, Dec 19, 2017 at 9:55 PM, Jerry He wrote: > AbstractTestIPC is a good test. And it will continue to work after this > proposed change, because we still want the server to be able to handle no > codec (and pb) case, for backward

Re: Cleanup and remove the code path where is no hbase.client.rpc.codec

2017-12-19 Thread Jerry He
AbstractTestIPC is a good test. And it will continue to work after this proposed change, because we still want the server to be able to handle no codec (and pb) case, for backward compatibility. The proposal is to remove the support of no codec from the RpcClient at the moment. There will always

Re: Cleanup and remove the code path where is no hbase.client.rpc.codec

2017-12-19 Thread ramkrishna vasudevan
So the proposal is to avoid the empty config and have a better defined config if we need No pb way? Ya I agree to it if this empty way seems odd to config. Any non - java client what will be the value for this config? Regards Ram On Wed, Dec 20, 2017 at 8:40 AM, 张铎(Duo Zhang)

Re: Cleanup and remove the code path where is no hbase.client.rpc.codec

2017-12-19 Thread Duo Zhang
See AbstractTestIPC, there is a testNoCodec. But I agree that we should have a default fallback codec always. 2017-12-20 11:02 GMT+08:00 Jerry He : > RPC_CODEC_CONF_KEY 'hbase.client.rpc.codec' is a property we use on the > client side to determine the RPC codec. > > It

Cleanup and remove the code path where is no hbase.client.rpc.codec

2017-12-19 Thread Jerry He
RPC_CODEC_CONF_KEY 'hbase.client.rpc.codec' is a property we use on the client side to determine the RPC codec. It currently has a strange logic. Whereas the default is KeyValueCodec, we allow a user to specify an empty string "" as the a way to indicate there is no codec class and we should not