Re: Did the branch-2.1 need the patch HBASE-21657 ?

2019-01-15 Thread OpenInx
Well, thanks all, Let me push this patch to branch-2 and master. On Tue, Jan 15, 2019 at 11:58 AM 张铎(Duo Zhang) wrote: > Sean Busbey 于2019年1月15日周二 上午11:33写道: > > > I'd much rather see this in 2.2.0 rather than squeeze it into a 2.1 > > maintenance release. > > > > Can 2.2 do rolling upgrade fro

Re: Did the branch-2.1 need the patch HBASE-21657 ?

2019-01-14 Thread Duo Zhang
Sean Busbey 于2019年1月15日周二 上午11:33写道: > I'd much rather see this in 2.2.0 rather than squeeze it into a 2.1 > maintenance release. > > Can 2.2 do rolling upgrade from earlier 2.y releases? There's nothing in > the ref guide, but I thought it didn't work due to some assignment change. > Need to mak

Re: Did the branch-2.1 need the patch HBASE-21657 ?

2019-01-14 Thread Sean Busbey
I'd much rather see this in 2.2.0 rather than squeeze it into a 2.1 maintenance release. Can 2.2 do rolling upgrade from earlier 2.y releases? There's nothing in the ref guide, but I thought it didn't work due to some assignment change. On Mon, Jan 14, 2019, 20:07 OpenInx bq. For me, I would say

Re: Did the branch-2.1 need the patch HBASE-21657 ?

2019-01-14 Thread OpenInx
bq. For me, I would say that let's start the 2.2.x release line soon? So user could benefit from the change after they upgrade to 2.2.x. Sound good. On Tue, Jan 15, 2019 at 11:05 AM OpenInx wrote: > b > > On Tue, Jan 15, 2019 at 10:54 AM 张铎(Duo Zhang) > wrote: > >> For me, I would say that let'

Re: Did the branch-2.1 need the patch HBASE-21657 ?

2019-01-14 Thread OpenInx
b On Tue, Jan 15, 2019 at 10:54 AM 张铎(Duo Zhang) wrote: > For me, I would say that let's start the 2.2.x release line soon? So user > could benefit from the change after they upgrade to 2.2.x. > > OpenInx 于2019年1月15日周二 上午10:21写道: > > > Sorry, here is a typo. > > > > > but not quite sure for bra

Re: Did the branch-2.1 need the patch HBASE-21657 ?

2019-01-14 Thread Duo Zhang
For me, I would say that let's start the 2.2.x release line soon? So user could benefit from the change after they upgrade to 2.2.x. OpenInx 于2019年1月15日周二 上午10:21写道: > Sorry, here is a typo. > > > but not quite sure for branch-1 . Discussion are welcome (smile). > but not quite sure for branch-2

Re: Did the branch-2.1 need the patch HBASE-21657 ?

2019-01-14 Thread OpenInx
Sorry, here is a typo. > but not quite sure for branch-1 . Discussion are welcome (smile). but not quite sure for branch-2.1 On Tue, Jan 15, 2019 at 10:17 AM OpenInx wrote: > Hi: > > In HBASE-21657, I simplified the path of estimatedSerialiedSize() & > estimatedSerialiedSizeOfCell() by moving

Did the branch-2.1 need the patch HBASE-21657 ?

2019-01-14 Thread OpenInx
Hi: In HBASE-21657, I simplified the path of estimatedSerialiedSize() & estimatedSerialiedSizeOfCell() by moving the general getSerializedSize() and heapSize() from ExtendedCell to Cell interface. It's a incompatible change in some case, such as if the upstream user implemented their own Cells, a