Re: Discussion: dropping filterKeyValue(Cell ignored) from FilterBase

2014-02-26 Thread Ted Yu
;>>> too many problems. >>>>> >>>>> If filterRowKey returns true filterKeyValue needs to be consistent >>> with >>>>> it. >>>>> filterKeyValue can assume that filterRowKey has already been called >>> for >>>

Re: Discussion: dropping filterKeyValue(Cell ignored) from FilterBase

2014-02-25 Thread Jeffrey Zhong
>> >> If filterRowKey returns true filterKeyValue needs to be consistent >>with >> >>it. >> >> filterKeyValue can assume that filterRowKey has already been called >>for >> >> the row. >> >> >> >> -- Lars >

Re: Discussion: dropping filterKeyValue(Cell ignored) from FilterBase

2014-02-24 Thread Ted Yu
returns true filterKeyValue needs to be consistent with > >>it. > >> filterKeyValue can assume that filterRowKey has already been called for > >> the row. > >> > >> -- Lars > >> > >> > >> > >>

Re: Discussion: dropping filterKeyValue(Cell ignored) from FilterBase

2014-02-24 Thread Jeffrey Zhong
can assume that filterRowKey has already been called for >> the row. >> >> -- Lars >> >> >> >> ____ >> From: Ted Yu >> To: "dev@hbase.apache.org" >> Sent: Monday, February 24, 2014 9:44 AM >> Subject: Discussion: dropping filterKeyValue(Cell ign

Re: Discussion: dropping filterKeyValue(Cell ignored) from FilterBase

2014-02-24 Thread Ted Yu
Value needs to be consistent with it. > filterKeyValue can assume that filterRowKey has already been called for > the row. > > -- Lars > > > > > From: Ted Yu > To: "dev@hbase.apache.org" > Sent: Monday, February 24, 2014

Re: Discussion: dropping filterKeyValue(Cell ignored) from FilterBase

2014-02-24 Thread lars hofhansl
Lars From: Ted Yu To: "dev@hbase.apache.org" Sent: Monday, February 24, 2014 9:44 AM Subject: Discussion: dropping filterKeyValue(Cell ignored) from FilterBase Hi, FilterBase.java has been marked @InterfaceAudience.Private since 0.96 I want to get your opinion on making pote

Discussion: dropping filterKeyValue(Cell ignored) from FilterBase

2014-02-24 Thread Ted Yu
Hi, FilterBase.java has been marked @InterfaceAudience.Private since 0.96 I want to get your opinion on making potential change to FilterBase - dropping filterKeyValue(Cell ignored). You can find background in HBASE-10485: PrefixFilter#filterKeyValue() should perform filtering on row key My think