Re: HTableInterface to extend java.io.Closeable

2012-01-10 Thread Ted Yu
HBASE-5172 has been filed for this. On Tue, Jan 10, 2012 at 9:59 AM, Stack wrote: > On Tue, Jan 10, 2012 at 9:53 AM, Lars H wrote: > > +1 this looks like an oversight > > > > Yes. Silly mistake. +1 on fixing. > St.Ack >

Re: HTableInterface to extend java.io.Closeable

2012-01-10 Thread Stack
On Tue, Jan 10, 2012 at 9:53 AM, Lars H wrote: > +1 this looks like an oversight > Yes. Silly mistake. +1 on fixing. St.Ack

Re: HTableInterface to extend java.io.Closeable

2012-01-10 Thread Lars H
+1 this looks like an oversight Ted Yu schrieb: >This is an interesting idea. > >HTable already implements Closeable. > >Do you mind filing a JIRA (and optionally a patch) ? > >Thanks > >On Tue, Jan 10, 2012 at 2:57 AM, Ioan Eugen Stan wrote: > >> Hello, >> >> In my code I get to write a lot of

Re: HTableInterface to extend java.io.Closeable

2012-01-10 Thread Ted Yu
This is an interesting idea. HTable already implements Closeable. Do you mind filing a JIRA (and optionally a patch) ? Thanks On Tue, Jan 10, 2012 at 2:57 AM, Ioan Eugen Stan wrote: > Hello, > > In my code I get to write a lot of boilerplate code to close a HTable > instance (see below snippet

HTableInterface to extend java.io.Closeable

2012-01-10 Thread Ioan Eugen Stan
Hello, In my code I get to write a lot of boilerplate code to close a HTable instance (see below snippet). Making HTableInterface extent java.io.Closeable would allow developers to use IOUtils.closeQuietly() from appache-commons or a similar method to cose a HTable instance without the extra code.