stop-hbase.sh never stopped once deployed the 0.91 trunk jar onto my hbase
setup. Figured out that the Meta regions were never closed and hbase would
stop only when logging in debug mode is enabled.
Here is the code snippet from HResionServer.java on HBaseTrunk:
else if (this.stopping && LOG.isDe
Good catch.
Also, I think in isOnlyMetaRegionsRemaining(), onlyMetaRegionsRemaining
should be initialized to true so that the cleanup at line 638 can proceed if
this.onlineRegions is empty.
Mind filing a bug ?
Thanks
On Fri, Jun 24, 2011 at 5:52 AM, Akash Ashok wrote:
> stop-hbase.sh never sto
Sure I shall file a Bug
Also I dnt think this condition checking itself is required in run()
if (!onlyMetaRegionsRemaining) {
onlyMetaRegionsRemaining = isOnlyMetaRegionsRemaining();
}
isOnlyMetaRegionsRemaining() is anyways gonna initialize it right ? without
checking the cond
I think the if condition below can be kept. It is an optimization because
isOnlyMetaRegionsRemaining() would loop through
this.onlineRegions.entrySet()
On Fri, Jun 24, 2011 at 7:08 AM, Akash Ashok wrote:
> Sure I shall file a Bug
>
> Also I dnt think this condition checking itself is required in
Yes I agree that would have been an optimization if that condition would
ever fail. But its a condition that will always pass because its a local
variable that initialized to false and thus if (!onlyMetaRegionsRemaining)
always passes .
Please correct me if I am missing something here.
Thanks
I agree.
On Fri, Jun 24, 2011 at 7:36 AM, Akash Ashok wrote:
> Yes I agree that would have been an optimization if that condition would
> ever fail. But its a condition that will always pass because its a local
> variable that initialized to false and thus if
> (!onlyMetaRegionsRemaining)
> a
