Re: On org.apache.hadoop.hbase.constraint

2020-07-24 Thread Duo Zhang
OK, seems no response. Will file an issue to redefine the API and change the IA annotations. 张铎(Duo Zhang) 于2020年6月8日周一 上午10:19写道: > Let's open an issue for this feature? > > Let's wait for a week, if still no use cases from users, I think we can do > some breaking changes on 3.0.0 to open the f

Re: On org.apache.hadoop.hbase.constraint

2020-06-07 Thread Duo Zhang
Let's open an issue for this feature? Let's wait for a week, if still no use cases from users, I think we can do some breaking changes on 3.0.0 to open the feature to end users. On 2.x, let's still keep the old classes. Thanks. Sean Busbey 于2020年6月8日周一 上午9:39写道: > I think it being labeled IA.P

Re: On org.apache.hadoop.hbase.constraint

2020-06-07 Thread Sean Busbey
I think it being labeled IA.Private is incorrect. The red guide talks about the feature and directly points folks to the javadoc of one of the IA.Private classes. http://hbase.apache.org/book.html#_constraints I'm all for us figuring out what the public surface should be and correcting this gap,

Re: On org.apache.hadoop.hbase.constraint

2020-06-07 Thread Stack
If IA.Private, it was for internal use only? Doesn't need a deprecation to change it? Please speak up if you are using the Constraint feature! Thanks, S On Sat, Jun 6, 2020 at 12:40 AM 张铎(Duo Zhang) wrote: > The related classes are marked as IA.Private which means it is not part of > our publi

Re: On org.apache.hadoop.hbase.constraint

2020-06-06 Thread Duo Zhang
The related classes are marked as IA.Private which means it is not part of our public API... That's why I check for shell support, as if there is no shell support, then users have no way to make use of it without breaking the InterfaceAudience rule... Jesse Yates 于2020年6月6日周六 上午1:04写道: > Not pa

Re: On org.apache.hadoop.hbase.constraint

2020-06-05 Thread Jesse Yates
Not particularly. Just because there is no shell integration though, doesn't mean it isn't used - it has been around for 5 years, which means someone likely has picked it up. You should probably ask on the user list and/or do a deprecation cycle to before just removing. --- Jesse Y

Re: On org.apache.hadoop.hbase.constraint

2020-06-05 Thread Duo Zhang
Seems only this issue has been finished. https://issues.apache.org/jira/browse/HBASE-4605 Which brought in these classes, but the later approach on adding shell support had been resolved as incomplete. https://issues.apache.org/jira/browse/HBASE-4879 So I guess there is no actual use in HBase y

Re: On org.apache.hadoop.hbase.constraint

2020-06-05 Thread Jesse Yates
Here is the original JIRA for the constraint work: https://issues.apache.org/jira/browse/HBASE-4999 Its a common DB feature, but not sure if folks actually use it in HBase. --- Jesse Yates @jesse_yates jesseyates.com On Fri, Jun 5, 2020 at 4:06 AM 张铎(D

On org.apache.hadoop.hbase.constraint

2020-06-05 Thread Duo Zhang
When removing HTableDescriptor on master branch, I found that it has been referenced by org.apache.hadoop.hbase.constraint package. The problem here is that, the API design is to pass in an HTableDescriptor and modify it directly, but now, TableDescriptor is immutable, so we need to redesign the A