Re: PreCommit whitespace failures on JVM crash dump files

2017-10-23 Thread Josh Elser
Thanks, Sean & Mike! Glad I'm not the only one who has seen this :) Re .gitignore: not that I can tell (touch'ing an hbase-server/hs_err_pid30492.log shows it up as untracked in my local checkout). On 10/23/17 12:12 PM, Sean Busbey wrote: we use git clean I think to do the post-checkout clea

Re: PreCommit whitespace failures on JVM crash dump files

2017-10-23 Thread Sean Busbey
we use git clean I think to do the post-checkout cleanup. are the dump files in our git ignore? On Mon, Oct 23, 2017 at 10:48 AM, Mike Drob wrote: > I've seen this too, but I don't understand how the dumps are present from > what should notionally be a clean checkout. > > On Mon, Oct 23, 2017 at

Re: PreCommit whitespace failures on JVM crash dump files

2017-10-23 Thread Mike Drob
I've seen this too, but I don't understand how the dumps are present from what should notionally be a clean checkout. On Mon, Oct 23, 2017 at 10:45 AM, Josh Elser wrote: > Hiya, > > Noticed a PreCommit failure from over the weekend on the whitespace (EOL, > tabs) checks [1][2]: > > e.g. > > ```

PreCommit whitespace failures on JVM crash dump files

2017-10-23 Thread Josh Elser
Hiya, Noticed a PreCommit failure from over the weekend on the whitespace (EOL, tabs) checks [1][2]: e.g. ``` ./hbase-server/hs_err_pid30492.log:637:73100-734f0 rw-p 00:00 0 ./hbase-server/hs_err_pid30492.log:638:734f0-75100 rw-p 00:00 0 ``` Any thoughts