Thank you both!
Sorry for the long silence, I just learned today that async-profile 3
has been released which has at least one breaking change
https://github.com/async-profiler/async-profiler/blob/master/CHANGELOG.md
I'll take a look at whether it is possible to just jump to that instead.
I'll p
I was the original developer of this feature. It existed in pretty much the
same form in Hive and was a straightforward port. The style of using enums to
encode and restrict supported parameters came from the origin. I thought it a
good idea, though, because this shells out to an external proces
Yea, that makes sense and was the one reason I could think of as well.
My concern with not backporting is that 3.x has been in development for
many years, and all of our users are on 2.x (or even 1.x). Duo is making
progress on 3.x now, but it's not clear when it will be released or,
further, when
Hi Bryan,
good question. We can probably keep supporting v1 if we wanted to but
I'm wondering if it's worth the effort (personally I think not).
I do agree that it should not be backported!
And I have wondered the same. If you look at the history of the issue
I kinda proposed forwarding parameter
Is it necessary to break support for v1?
It would be fine to merge this to master and branch-3. But I think this
change falls into the "Dependency Compatibility" portion of our
compatibility guidelines[1]. If so, then we should not backport to branch-2
or 2.x.
Generally, I have previously wondere
