Re: Review Request: HBASE-1923. Bulk load into existing tables

--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/87/#review112 --- Ship it! Reviewed changes between v2 and v3. It looks like they were lost

Re: Review Request: HBASE-1923. Bulk load into existing tables

--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/87/#review108 --- Ship it! This is a killer feature. Ship it. There is one nitpick in the b

Re: Review Request: HBASE-1923. Bulk load into existing tables

--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/87/ --- (Updated 2010-06-01 00:33:30.030753) Review request for hbase, stack and Jonathan Gra

Re: Review Request: HBASE-1923. Bulk load into existing tables

Request: HBASE-1923. Bulk load into existing tables > To: dev@hbase.apache.org > Cc: jirapos...@review.hbase.org, "Todd Lipcon" , > st...@duboce.net, "Jonathan Gray" > Date: Monday, May 31, 2010, 10:35 PM > Lets not put this in branch... focus > on making tru

Re: Review Request: HBASE-1923. Bulk load into existing tables

Lets not put this in branch... focus on making trunk releasable not extending branch's life. On May 30, 2010 2:13 PM, "Todd Lipcon" wrote: > > >> On 2010-05-28 17:19:22, stack wrote: >> > src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java, line 264 >> >

Re: Review Request: HBASE-1923. Bulk load into existing tables

> On 2010-05-28 17:19:22, stack wrote: > > src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java, > > line 234 > > > > > > Why two types? Is this legacy? KV has advantage of being able to > > carry a Delete >

Re: Review Request: HBASE-1923. Bulk load into existing tables

--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/87/ --- (Updated 2010-05-31 00:22:24.084089) Review request for hbase, stack and Jonathan Gra

Re: Review Request: HBASE-1923. Bulk load into existing tables

--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/87/ --- (Updated 2010-05-30 16:13:22.509910) Review request for hbase, stack and Jonathan Gra

Re: Review Request: HBASE-1923. Bulk load into existing tables

> On 2010-05-28 17:19:22, stack wrote: > > src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java, line 264 > > > > > > Is this patch for trunk or branch? If branch, this addition might > > break RPC. It might be ok o

Re: Review Request: HBASE-1923. Bulk load into existing tables

--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/87/#review97 --- Ship it! Looks good to me. I don't have any major issues so go ahead and co

Re: Review Request: HBASE-1923. Bulk load into existing tables

--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/87/#review96 --- src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java

Re: Review Request: HBASE-1923. Bulk load into existing tables

--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/87/#review90 --- src/main/java/org/apache/hadoop/hbase/util/Bytes.java

Re: Review Request: HBASE-1923. Bulk load into existing tables

--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/87/#review76 --- src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java

Review Request: HBASE-1923. Bulk load into existing tables

--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/87/ --- Review request for hbase, stack and Jonathan Gray. Summary --- Here's a first pa