Re: adding a profile to build thrift generated classes

2014-07-31 Thread Srikanth Srungarapu
+1 on the idea. Currently, there is a profile for generating protobuf files (http://hbase.apache.org/book/build.html), but I couldn't find any analog for thrift. So, this can come handy when needed. On Wed, Jul 30, 2014 at 10:47 PM, Sean Busbey bus...@cloudera.com wrote: Hiya! Currently, the

Re: adding a profile to build thrift generated classes

2014-07-31 Thread Sean Busbey
Yep, I'll get a JIRA and patch together early next week. -- Sean On Jul 31, 2014 7:28 PM, Nick Dimiduk ndimi...@gmail.com wrote: So long as you can enforce that the thrift binary version matches whatever the pom.xml requires, it's fine by me. You want to cook up a patch, Sean? On Wed, Jul

adding a profile to build thrift generated classes

2014-07-30 Thread Sean Busbey
Hiya! Currently, the only instructions for generating our RPC classes via thrift that I can find are in a package javadoc[1]. While I doubt we rebuild them very often, I was thinking we could ease the process by adding a maven profile that took care of the rebuilding and copying into place. It