Re: need a little help with a patch submission

2012-03-13 Thread Shrijeet Paliwal
Yes it does. On Tue, Mar 13, 2012 at 2:37 PM, Sujee Maniyam wrote: > On Mon, Mar 12, 2012 at 2:32 PM, lars hofhansl > wrote: > > Hi Sujee, > > > > you just attach a new file. > > I name my patches like this: -v.txt, but that is a > matter of taste.(So in your case that would "5198-v2.txt") > >

Re: need a little help with a patch submission

2012-03-13 Thread N Keywal
Hi Sujee, If you want to (re)submit it, you don't have to delete the previous patch. However you need to do things in this exact order: 1 - cancel patch 2 - attach new patch 3 - submit. If you reverse 1 & 2, you patch won't be applied. Good luck :-) N. On Tue, Mar 13, 2012 at 10:37 PM, Sujee M

Re: need a little help with a patch submission

2012-03-13 Thread Sujee Maniyam
On Mon, Mar 12, 2012 at 2:32 PM, lars hofhansl wrote: > Hi Sujee, > > you just attach a new file. > I name my patches like this: -v.txt, but that is a matter of > taste.(So in your case that would "5198-v2.txt") > -- Lars thanks Lars, one more question. So no need to delete the previous patch f

Re: need a little help with a patch submission

2012-03-12 Thread lars hofhansl
Re: need a little help with a patch submission ok guys, thanks for the replies. I will regenerate the patch. Now a little process question, on submitting the revised patch: should I delete the previous patch attachment,  cancel patch, and attach another patch? or should I leave the previous

Re: need a little help with a patch submission

2012-03-12 Thread Sujee Maniyam
ok guys, thanks for the replies. I will regenerate the patch. Now a little process question, on submitting the revised patch: should I delete the previous patch attachment, cancel patch, and attach another patch? or should I leave the previous attachment and attach the second one? thanks Sujee

Re: need a little help with a patch submission

2012-03-12 Thread Doug Meil
I'll update the book with that... On 3/12/12 3:45 PM, "Harsh J" wrote: >Hi, > >Use {{git diff --no-prefix}} when generating your patches, as the QA >bot assumes its an SVN patch and thats how you can make it compatible. > >But please file a JIRA to add such a note to the book where it >recomm

Re: need a little help with a patch submission

2012-03-12 Thread Harsh J
Hi, Use {{git diff --no-prefix}} when generating your patches, as the QA bot assumes its an SVN patch and thats how you can make it compatible. But please file a JIRA to add such a note to the book where it recommends "git diff". (With a --no-prefix doc patch if you please ;)) On Tue, Mar 13, 20

Re: need a little help with a patch submission

2012-03-12 Thread Shrijeet Paliwal
Sujee, Try "git diff --no-prefix" -Shrijeet On Mon, Mar 12, 2012 at 12:39 PM, Sujee Maniyam wrote: > > https://issues.apache.org/jira/browse/HBASE-5198?focusedCommentId=13226635&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13226635 > > I don't quite understand w

Re: need a little help with a patch submission

2012-03-12 Thread Gregory Chanan
Sujee, I think you need to create the patch with the --no-prefix option in git. Greg On Mon, Mar 12, 2012 at 12:39 PM, Sujee Maniyam wrote: > > https://issues.apache.org/jira/browse/HBASE-5198?focusedCommentId=13226635&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comme

need a little help with a patch submission

2012-03-12 Thread Sujee Maniyam
https://issues.apache.org/jira/browse/HBASE-5198?focusedCommentId=13226635&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13226635 I don't quite understand why the patching failed. I am relatively a newbie and following this : http://hbase.apache.org/book/submitting