Sean Busbey created HBASE-12256:
---
Summary: Update patch submission guidelines to call out binary
file support
Key: HBASE-12256
URL: https://issues.apache.org/jira/browse/HBASE-12256
Project: HBase
[
https://issues.apache.org/jira/browse/HBASE-11937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Misty Stanley-Jones resolved HBASE-11937.
-
Resolution: Duplicate
> Update patch submission guidelines to stop using -
Sean Busbey created HBASE-11937:
---
Summary: Update patch submission guidelines to stop using
--no-prefix
Key: HBASE-11937
URL: https://issues.apache.org/jira/browse/HBASE-11937
Project: HBase
Yes it does.
On Tue, Mar 13, 2012 at 2:37 PM, Sujee Maniyam wrote:
> On Mon, Mar 12, 2012 at 2:32 PM, lars hofhansl
> wrote:
> > Hi Sujee,
> >
> > you just attach a new file.
> > I name my patches like this: -v.txt, but that is a
> matter of taste.(So in your case that would "5198-v2.txt")
> >
Hi Sujee,
If you want to (re)submit it, you don't have to delete the previous patch.
However you need to do things in this exact order:
1 - cancel patch
2 - attach new patch
3 - submit.
If you reverse 1 & 2, you patch won't be applied.
Good luck :-)
N.
On Tue, Mar 13, 2012 at 10:37 PM, Sujee M
On Mon, Mar 12, 2012 at 2:32 PM, lars hofhansl wrote:
> Hi Sujee,
>
> you just attach a new file.
> I name my patches like this: -v.txt, but that is a matter of
> taste.(So in your case that would "5198-v2.txt")
> -- Lars
thanks Lars,
one more question. So no need to delete the previous patch f
Re: need a little help with a patch submission
ok guys, thanks for the replies.
I will regenerate the patch.
Now a little process question, on submitting the revised patch:
should I delete the previous patch attachment, cancel patch, and
attach another patch?
or
should I leave the previous
ok guys, thanks for the replies.
I will regenerate the patch.
Now a little process question, on submitting the revised patch:
should I delete the previous patch attachment, cancel patch, and
attach another patch?
or
should I leave the previous attachment and attach the second one?
thanks
Sujee
I'll update the book with that...
On 3/12/12 3:45 PM, "Harsh J" wrote:
>Hi,
>
>Use {{git diff --no-prefix}} when generating your patches, as the QA
>bot assumes its an SVN patch and thats how you can make it compatible.
>
>But please file a JIRA to add such a note to the book where it
>recomm
Hi,
Use {{git diff --no-prefix}} when generating your patches, as the QA
bot assumes its an SVN patch and thats how you can make it compatible.
But please file a JIRA to add such a note to the book where it
recommends "git diff".
(With a --no-prefix doc patch if you please ;))
On Tue, Mar 13, 20
Sujee,
Try "git diff --no-prefix"
-Shrijeet
On Mon, Mar 12, 2012 at 12:39 PM, Sujee Maniyam wrote:
>
> https://issues.apache.org/jira/browse/HBASE-5198?focusedCommentId=13226635&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13226635
>
> I don't quite understand w
Sujee,
I think you need to create the patch with the --no-prefix option in git.
Greg
On Mon, Mar 12, 2012 at 12:39 PM, Sujee Maniyam wrote:
>
> https://issues.apache.org/jira/browse/HBASE-5198?focusedCommentId=13226635&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comme
https://issues.apache.org/jira/browse/HBASE-5198?focusedCommentId=13226635&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13226635
I don't quite understand why the patching failed.
I am relatively a newbie and following this :
http://hbase.apache.org/book/submitting
k prove their worth by hitting back. - Piet Hein
>(via Tom White)
>
>
>- Original Message -
>> From: Ted Yu
>> To: dev@hbase.apache.org
>> Cc: br...@cloudera.com; Doug Meil
>> Sent: Sunday, August 21, 2011 12:09 PM
>> Subject: patch submission
&
anding as well.
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein (via
Tom White)
- Original Message -
> From: Ted Yu
> To: dev@hbase.apache.org
> Cc: br...@cloudera.com; Doug Meil
> Sent: Sunday, August 21, 2011 12:09 PM
A common question among HBase contributors, especially hadoop
contributors/committers, is related to the 'Submit patch' button.
Clicking the button wouldn't trigger build on Jenkins. The setup here is
different from that for hadoop.
My understanding is that clicking the button means the author is
Thanks Todd.
2011/8/7 Todd Lipcon
> The HBase hudson has never been set up to run tests automatically like
> the Hadoop one does. So, you should run affected tests locally and
> paste the results.
>
> -Todd
>
> On Sun, Aug 7, 2011 at 3:58 PM, lohit wrote:
> > Hi,
> >
> > I submitted patch on a
The HBase hudson has never been set up to run tests automatically like
the Hadoop one does. So, you should run affected tests locally and
paste the results.
-Todd
On Sun, Aug 7, 2011 at 3:58 PM, lohit wrote:
> Hi,
>
> I submitted patch on a JIRA (via submit patch button) but haven't seen
> Hudso
Hi,
I submitted patch on a JIRA (via submit patch button) but haven't seen
Hudson pick up the patch for QA runs.
Is there different method, anyone has link to patch queue?
I also see latest trunk build is broken. Do I have to resubmit my patch.
--
Have a Nice Day!
Lohit
19 matches
Mail list logo
