[jira] Updated: (HTTPCLIENT-967) allow cache to be configured as a non-shared (private) cache

2010-07-12 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated HTTPCLIENT-967: - Fix Version/s: Future > allow cache to be configured as a non-shared (private

[jira] Resolved: (HTTPCLIENT-963) client cache does not respect 'Cache-Control: no-store' on requests

2010-07-12 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-963. -- Fix Version/s: 4.1 Alpha3 Resolution: Fixed Patch (take 3) checked i

[jira] Created: (HTTPCLIENT-967) allow cache to be configured as a non-shared (private) cache

2010-07-12 Thread Jonathan Moore (JIRA)
allow cache to be configured as a non-shared (private) cache Key: HTTPCLIENT-967 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-967 Project: HttpComponents HttpClient Issue

[jira] Updated: (HTTPCLIENT-963) client cache does not respect 'Cache-Control: no-store' on requests

2010-07-12 Thread Jonathan Moore (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Moore updated HTTPCLIENT-963: -- Attachment: no-store-requests-3.patch Third time's a charm, hopefully. This patch i

[jira] Commented: (HTTPCLIENT-963) client cache does not respect 'Cache-Control: no-store' on requests

2010-07-12 Thread Jonathan Moore (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887493#action_12887493 ] Jonathan Moore commented on HTTPCLIENT-963: --- Ugh, I'll try again, sorry. :)

[jira] Commented: (HTTPCLIENT-963) client cache does not respect 'Cache-Control: no-store' on requests

2010-07-12 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887489#action_12887489 ] Oleg Kalnichevski commented on HTTPCLIENT-963: -- Hhhm. The second does not

[jira] Resolved: (HTTPCLIENT-962) client cache may be a shared cache but is caching responses to requests with Authorization headers

2010-07-12 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-962. -- Fix Version/s: 4.1 Alpha3 Resolution: Fixed Closing as FIXED. Plea

RE: [HttpCache][PATCH] Caching API review

2010-07-12 Thread Oleg Kalnichevski
On Mon, 2010-07-12 at 15:04 -0400, Moore, Jonathan wrote: > Hi Oleg, I'm not sure what you're trying to accomplish here. > This change was not driven by any practical requirement. I was just going through the code and the existing behavior of the #updateCacheEntry method took me completely by sur

RE: [HttpCache][PATCH] Caching API review

2010-07-12 Thread Moore, Jonathan
Hi Oleg, I'm not sure what you're trying to accomplish here. You're right that sometimes multiple entries need to get updated at the same time in a consistent fashion, which is why the callback is provided (and then the BasicHttpCache marks this as a synchronized method). It seems like your patch

Re: [HttpCache][PATCH] Caching API review

2010-07-12 Thread Richie Jefts
I dislike getLock(). It exposes implementation details. Why not keep the old style of code and make it more explicit it may modify multiple entries. Something like. BasicHttpCache.update(String url, HttpCacheUpdate update); It ensures callers don't have to mess with the lock since it all happe

RE: HttpClient 4.1 API freeze / Caching API

2010-07-12 Thread Moore, Jonathan
If we go with #3, we'll have to be careful about the conversion of protected methods to private ones, as this will likely break a bunch of unit tests. Generally speaking, though, the caching module follows the Façade design pattern, so most of the actual public API probably just wants to be what

[HttpCache][PATCH] Caching API review

2010-07-12 Thread Oleg Kalnichevski
Jon et al I started looking at the Caching API more closely primarily to find out how difficult / feasible it should be to put together alternative cache backends such as echache or file system based. I stumbled upon a few minor issues I thought I should discuss with you. (1) HttpCacheUpdateCall

HttpClient 4.1 API freeze / Caching API

2010-07-12 Thread Oleg Kalnichevski
Folks I would like to start moving towards the freeze of 4.1 API. All new features added in trunk since 4.0 seem reasonably okay. The only thing that still blocks the 4.1-beta1 release is the the relatively untested API of the recently added caching module. I personally find it difficult to decide

[jira] Updated: (HTTPCLIENT-963) client cache does not respect 'Cache-Control: no-store' on requests

2010-07-12 Thread Jonathan Moore (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Moore updated HTTPCLIENT-963: -- Attachment: no-store-requests-2.patch I've attached a rebuilt patch against trunk.

Re: Release new parent POM 4.1

2010-07-12 Thread sebb
On 8 July 2010 22:28, sebb wrote: > On 8 July 2010 20:23, Oleg Kalnichevski wrote: >> ... >>> > --- >>> > Cannot find a matching staging profile! >>> > You can get technical details here. >>> > Please continue your visit at our home page. >>> > --- >>> > >>> > Is there anything else that needs to

[jira] Commented: (HTTPCLIENT-962) client cache may be a shared cache but is caching responses to requests with Authorization headers

2010-07-12 Thread Jonathan Moore (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887374#action_12887374 ] Jonathan Moore commented on HTTPCLIENT-962: --- Ok, I think we can close this is

[jira] Commented: (HTTPCLIENT-963) client cache does not respect 'Cache-Control: no-store' on requests

2010-07-12 Thread Jonathan Moore (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887375#action_12887375 ] Jonathan Moore commented on HTTPCLIENT-963: --- Hi Oleg, No problem, I'll regen