[jira] Created: (HTTPCORE-230) Need time related metrics data

2010-07-13 Thread Zhang Guilin (JIRA)
Need time related metrics data -- Key: HTTPCORE-230 URL: https://issues.apache.org/jira/browse/HTTPCORE-230 Project: HttpComponents HttpCore Issue Type: New Feature Components: HttpCore Affects Versi

HttpCore NIO hurt by JDK bug?

2010-07-13 Thread Harold Lee
Regarding this JDK bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6403933 I think we are experiencing this using HttpCore on Linux with Java 1.6. We wind up leaking socket descriptors until the JVM process runs out. We also wind up having to start a new reactor thread, which creates a new

RE: [HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread Oleg Kalnichevski
I checked the patch in with some minor tweaks. As long as HttpCache is expected to be able to update just one entry as an atomic unit of work I am fine with the API as is. Please review. Oleg ... > -Original Message- > From: Moore, Jonathan [mailto:jonathan_mo...@comcast.com] > Sent:

[jira] Resolved: (HTTPCORE-229) IOOBE in case of UTF-8 encoded http element(headers)

2010-07-13 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCORE-229. Resolution: Fixed Fixed in SVN trunk and 4.0.x branch. I figured it was cheaper a

[jira] Updated: (HTTPCORE-229) IOOBE in case of UTF-8 encoded http element(headers)

2010-07-13 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated HTTPCORE-229: --- Fix Version/s: 4.0.2 Affects Version/s: 4.1-beta1 4.0

RE: [HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread Oleg Kalnichevski
On Tue, 2010-07-13 at 10:38 -0400, Moore, Jonathan wrote: > Sorry, I'm not clear on whether you still want me to open a JIRA issue > about this or not, given that my patch seems to have gotten through. I'm > happy to do it, though. > > Jon > I think it is no longer needed. Oleg --

[jira] Commented: (HTTPCORE-229) IOOBE in case of UTF-8 encoded http element(headers)

2010-07-13 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1288#action_1288 ] Oleg Kalnichevski commented on HTTPCORE-229: Igor, My bad. I responded witho

RE: [HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread Moore, Jonathan
Sorry, I'm not clear on whether you still want me to open a JIRA issue about this or not, given that my patch seems to have gotten through. I'm happy to do it, though. Jon -Original Message- From: Oleg Kalnichevski [mailto:ol...@apache.org] Sent: Tuesday, July 13, 2010 10:20 AM To: HttpC

[jira] Commented: (HTTPCORE-229) IOOBE in case of UTF-8 encoded http element(headers)

2010-07-13 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887773#action_12887773 ] Sebb commented on HTTPCORE-229: --- AIUI, header values must either be in ISO-8859-1 or must b

[jira] Updated: (HTTPCORE-229) IOOBE in case of UTF-8 encoded http element(headers)

2010-07-13 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated HTTPCORE-229: --- Fix Version/s: 4.1 Priority: Minor (was: Major) Igor, Javadocs are wrong

RE: [HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread Campbell, Joseph
FYI - Jon, I got your Atomic patch as a .txt file no problem. Joe -- "Strength of numbers is the delight of the timid. The Valiant in spirit glory in fighting alone." Mahatma Gandhi Joe Campbell | one comcast center | philadelphia, pa 19103 | 215.286.5073 -Original Message- From

Re: [HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread sebb
I got the second one "Ok, *this* time I've remembered to actually attach the patch" But it's usually easier to find patches again if they are attached to a JIRA. On 13 July 2010 15:20, Moore, Jonathan wrote: > Ok, can someone else let me know if my patches are showing up? They're > getting strip

RE: [HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread Oleg Kalnichevski
On Tue, 2010-07-13 at 10:20 -0400, Moore, Jonathan wrote: > Ok, can someone else let me know if my patches are showing up? They're > getting stripped from my messages somewhere along the line, and I don't > know whether it's before they hit the list or if my inbound mail server > is stripping them

RE: [HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread Moore, Jonathan
Ok, can someone else let me know if my patches are showing up? They're getting stripped from my messages somewhere along the line, and I don't know whether it's before they hit the list or if my inbound mail server is stripping them (although I've received Oleg's patches ok). Jon -Original Me

RE: [HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread Oleg Kalnichevski
On Tue, 2010-07-13 at 10:03 -0400, Moore, Jonathan wrote: > Ok, I've attached a much simpler patch that only uses the callback in a > non-surprising way. > > Jon > Jon I guess the patch got stripped. Could you please raise new JIRA issue and attach the patch to it? Oleg

[jira] Commented: (HTTPCORE-229) IOOBE in case of UTF-8 encoded http element(headers)

2010-07-13 Thread Igor Mikhailuk (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887769#action_12887769 ] Igor Mikhailuk commented on HTTPCORE-229: - Yeap. RFC is very good... But some ht

RE: [HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread Moore, Jonathan
Ok, *this* time I've remembered to actually attach the patch. Sigh. :) -Original Message- From: Moore, Jonathan Sent: Tuesday, July 13, 2010 10:16 AM To: 'HttpComponents Project' Subject: RE: [HttpCache][PATCH] Caching API review (take 2) Reattaching my patch as a .txt file -- the copy o

RE: [HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread Moore, Jonathan
Reattaching my patch as a .txt file -- the copy of my message I got back had the patch stripped from it, so I'm not sure it went through to you all. Jon -Original Message- From: Moore, Jonathan [mailto:jonathan_mo...@comcast.com] Sent: Tuesday, July 13, 2010 10:03 AM To: HttpComponents P

[jira] Commented: (HTTPCORE-229) IOOBE in case of UTF-8 encoded http element(headers)

2010-07-13 Thread James Abley (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887765#action_12887765 ] James Abley commented on HTTPCORE-229: -- That Location header looks wrong to me? I th

RE: [HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread Moore, Jonathan
Ok, I've attached a much simpler patch that only uses the callback in a non-surprising way. Jon -Original Message- From: Moore, Jonathan [mailto:jonathan_mo...@comcast.com] Sent: Tuesday, July 13, 2010 9:32 AM To: HttpComponents Project Subject: RE: [HttpCache][PATCH] Caching API review

[jira] Created: (HTTPCORE-229) IOOBE in case of UTF-8 encoded http element(headers)

2010-07-13 Thread Igor Mikhailuk (JIRA)
IOOBE in case of UTF-8 encoded http element(headers) Key: HTTPCORE-229 URL: https://issues.apache.org/jira/browse/HTTPCORE-229 Project: HttpComponents HttpCore Issue Type: Bug Co

RE: [HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread Moore, Jonathan
I agree that the lack of explicit locking is good; however, I wonder if the interface is now offering something that implementations can't always provide, because not all backing stores will be able to offer this level of transaction. The primary example would be several JVMs in a pool of app serv

[HttpCache][PATCH] Caching API review (take 2)

2010-07-13 Thread Oleg Kalnichevski
Jon et al How about a slightly different take? No explicit locking is needed. The callback stays but is made more generic allowing for all kinds of cache mutations, not just variant updates. Can you live with this change? Oleg Index: httpclient-cache/src/test/java/org/apache/http/impl/client/cac