[jira] Closed: (HTTPCORE-246) ThrottlingHttpClientHandler triggers EventListener.connectionClosed twice

[ https://issues.apache.org/jira/browse/HTTPCORE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Pon closed HTTPCORE-246. -- Looks good to me. And thanks for the tip - I'll change my logic to utilize finalizeContext instead. >

Re: svn commit: r1044411

On 10 December 2010 18:20, Oleg Kalnichevski wrote: > On Fri, 2010-12-10 at 17:15 +, sebb wrote: >> > +    public final boolean equals(Object obj) { >> > +        if (obj == null) return false; >> >> That null check not necessary, because null fails the instanceof check. >> > > I think it save

Re: svn commit: r1044411

On Fri, 2010-12-10 at 17:15 +, sebb wrote: > > +public final boolean equals(Object obj) { > > +if (obj == null) return false; > > That null check not necessary, because null fails the instanceof check. > I think it saves one comparison operation. Feel free to remove it, but ideal

Re: svn commit: r1044411 - /httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/conn/routing/HttpRoute.java

On 10 December 2010 15:55, wrote: > Author: olegk > Date: Fri Dec 10 15:55:41 2010 > New Revision: 1044411 > > URL: http://svn.apache.org/viewvc?rev=1044411&view=rev > Log: > Made #equals and #hashCode of HttpRoute consistent with implementations in > other classes > > Modified: >     > httpcomp

[jira] Commented: (HTTPCLIENT-1032) cache revalidation of variants does not update original variant entry

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970218#action_12970218 ] Michajlo Matijkiw commented on HTTPCLIENT-1032: --- With this change do you

[jira] Updated: (HTTPCLIENT-975) add support to caching module for RFC 5861 (stale-on-error and stale-while-revalidate)

[ https://issues.apache.org/jira/browse/HTTPCLIENT-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michajlo Matijkiw updated HTTPCLIENT-975: - Attachment: stale-while-revalidate.patch This patch adds the 'stale-while-rev

[jira] Resolved: (HTTPCLIENT-1033) HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved HTTPCLIENT-1033. -- Resolution: Fixed OK, applied > HttpRoute.equals(Object o) is quite inefficient, as it does not t

[jira] Moved: (HTTPCLIENT-1033) HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb moved HTTPCORE-248 to HTTPCLIENT-1033: --- Component/s: (was: HttpCore) HttpConn

[jira] Commented: (HTTPCORE-248) HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic

[ https://issues.apache.org/jira/browse/HTTPCORE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970169#action_12970169 ] Oleg Kalnichevski commented on HTTPCORE-248: Looks good to me. Oleg > HttpR

[jira] Updated: (HTTPCORE-248) HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic

[ https://issues.apache.org/jira/browse/HTTPCORE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated HTTPCORE-248: -- Attachment: HTTPCORE-248.patch > HttpRoute.equals(Object o) is quite inefficient, as it does not take full >

[jira] Created: (HTTPCORE-248) HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic

HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic - Key: HTTPCORE-248 URL: https://issues.apache.org/jira/brows

[jira] Commented: (HTTPCLIENT-1032) cache revalidation of variants does not update original variant entry

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970145#action_12970145 ] Oleg Kalnichevski commented on HTTPCLIENT-1032: --- That's perfectly all ri

[jira] Commented: (HTTPCLIENT-1032) cache revalidation of variants does not update original variant entry

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970142#action_12970142 ] Jon Moore commented on HTTPCLIENT-1032: --- Oleg, I'm in the process of figuring t

[jira] Resolved: (HTTPCORE-246) ThrottlingHttpClientHandler triggers EventListener.connectionClosed twice

[ https://issues.apache.org/jira/browse/HTTPCORE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCORE-246. Resolution: Fixed Fix Version/s: 4.1.1 Bryan, I fixed the bug in SVN trun

[jira] Resolved: (HTTPCORE-247) HttpCore Manual Simplified Chinese

[ https://issues.apache.org/jira/browse/HTTPCORE-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCORE-247. Resolution: Fixed Fix Version/s: (was: 4.1) 4.1.1 C

[jira] Resolved: (HTTPCLIENT-1028) HttpClient Manual Simplified Chinese

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-1028. --- Resolution: Fixed Fix Version/s: 4.1.0 Committed to the contrib p

[jira] Commented: (HTTPCLIENT-1026) Properly close resources

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970116#action_12970116 ] Oleg Kalnichevski commented on HTTPCLIENT-1026: --- Eduardo Patches do not