[jira] [Commented] (HTTPCLIENT-1578) Regression between v4.1 and v4.1.1 regarding validation of SSL certificates for servers with multiple VirtualHost serving HTTPS

2014-11-11 Thread Richard Comblen (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207752#comment-14207752 ] Richard Comblen commented on HTTPCLIENT-1578: - Hi Oleg, thanks for looki

[GitHub] httpcore pull request: Reduce synchronized scopes in IOSessionImpl

2014-11-11 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpcore/pull/7#issuecomment-62673889 Pull request simplified. The only blocking operation is .close() (because of dup2 called by preClose0), so no double checks required. Just synchronized scope of .close(

[jira] [Commented] (HTTPCLIENT-1575) PoolingHttpClientConnectionManager.setMaxPerRoute accepts, but ignores, HttpRoutes with default ports

2014-11-11 Thread Joseph Walton (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207503#comment-14207503 ] Joseph Walton commented on HTTPCLIENT-1575: --- I think using those standard d

[GitHub] httpcore pull request: adding a callback to be executed when reusi...

2014-11-11 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/6#issuecomment-62619433 I committed the patch with some tweaks to SVN trunk and 4.4.x branch. I added a similar method to the blocking pool implementation for the sake of consistency and also took

[jira] [Resolved] (HTTPCLIENT-1578) Regression between v4.1 and v4.1.1 regarding validation of SSL certificates for servers with multiple VirtualHost serving HTTPS

2014-11-11 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-1578. --- Resolution: Invalid > Regression between v4.1 and v4.1.1 regarding valida

[jira] [Commented] (HTTPCLIENT-1578) Regression between v4.1 and v4.1.1 regarding validation of SSL certificates for servers with multiple VirtualHost serving HTTPS

2014-11-11 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207013#comment-14207013 ] Oleg Kalnichevski commented on HTTPCLIENT-1578: --- Works fine for me with

[jira] [Commented] (HTTPCLIENT-1575) PoolingHttpClientConnectionManager.setMaxPerRoute accepts, but ignores, HttpRoutes with default ports

2014-11-11 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206529#comment-14206529 ] Oleg Kalnichevski commented on HTTPCLIENT-1575: --- Patch committed to SVN

[GitHub] httpcore pull request: Reduce synchronized scopes in IOSessionImpl

2014-11-11 Thread hirthwork
GitHub user hirthwork opened a pull request: https://github.com/apache/httpcore/pull/7 Reduce synchronized scopes in IOSessionImpl Currently IOSessionImpl has too many synchronized methods which results in poor performance on high load. Changes consist of two commits: First

[jira] [Created] (HTTPCLIENT-1578) Regression between v4.1 and v4.1.1 regarding validation of SSL certificates for servers with multiple VirtualHost serving HTTPS

2014-11-11 Thread Richard Comblen (JIRA)
Richard Comblen created HTTPCLIENT-1578: --- Summary: Regression between v4.1 and v4.1.1 regarding validation of SSL certificates for servers with multiple VirtualHost serving HTTPS Key: HTTPCLIENT-1578 URL: ht

Re: Adding a Callback to Trigger on Reusing a Connection

2014-11-11 Thread Malaka Gallage
Hi Oleg, A pull request is made as per the suggestion. https://github.com/apache/httpcore/pull/6 Thanks Malaka On Mon, Nov 10, 2014 at 7:08 PM, Oleg Kalnichevski wrote: > On Mon, 2014-11-10 at 17:33 +0530, Malaka Gallage wrote: > > Hello everyone, > > > > I'm using NIO version 4.2.5 and I'm fa

[GitHub] httpcore pull request: adding a callback to be executed when reusi...

2014-11-11 Thread mpgallage
GitHub user mpgallage opened a pull request: https://github.com/apache/httpcore/pull/6 adding a callback to be executed when reusing an established connection ... You can merge this pull request into a Git repository by running: $ git pull https://github.com/mpgallage/httpcore