Re: [VOTE] Release HttpComponents Core 4.4.2 based on RC1

2015-08-25 Thread Gary Gregory
On Tue, Aug 25, 2015 at 3:22 AM, Oleg Kalnichevski wrote: > On Mon, 2015-08-24 at 22:13 -0700, Gary Gregory wrote: > > Running 'mvn test', I get: > > > > > testSSLHanskshakeProtocolMismatch2(org.apache.http.ssl.TestSSLContextBuilder) > > Time elapsed: 0.031 sec <<< ERROR! > > java.lang.Exceptio

[jira] [Commented] (HTTPCORE-406) Refactor some test code to be sharable with OSGi tests

2015-08-25 Thread Benson Margulies (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711370#comment-14711370 ] Benson Margulies commented on HTTPCORE-406: --- https://github.com/apache/httpcor

[GitHub] httpcore pull request: Httpcore-406: more tests

2015-08-25 Thread bimargulies
GitHub user bimargulies opened a pull request: https://github.com/apache/httpcore/pull/12 Httpcore-406: more tests These are _really_ osgi tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bimargulies/httpcore HTTPCORE-406-mo

[GitHub] httpclient pull request: URIBuilder extended for new method for em...

2015-08-25 Thread wThomas84
Github user wThomas84 commented on the pull request: https://github.com/apache/httpclient/pull/35#issuecomment-134568319 Hi, I think its the discussion about a convenience method here that might simplify adoption and usage of this utility class. Another parameter adds complexity to

[GitHub] httpclient pull request: URIBuilder extended for new method for em...

2015-08-25 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/httpclient/pull/35#issuecomment-134563257 I'd rather see a boolean parameter at the end, not another method name. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] httpclient pull request: URIBuilder extended for new method for em...

2015-08-25 Thread CanardSauvage
Github user CanardSauvage commented on the pull request: https://github.com/apache/httpclient/pull/35#issuecomment-134560658 Maybe complete is the wrong word. The class is for proper URL building and this is a convenience method that helps to reduce code. It would make the class easie

[jira] [Commented] (HTTPCORE-406) Refactor some test code to be sharable with OSGi tests

2015-08-25 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711106#comment-14711106 ] Oleg Kalnichevski commented on HTTPCORE-406: The first option is the way to

[GitHub] httpclient pull request: URIBuilder extended for new method for em...

2015-08-25 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/httpclient/pull/35#issuecomment-134559060 You are responsible for *your* data and we for the proper URL building. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Created] (HTTPCORE-406) Refactor some test code to be sharable with OSGi tests

2015-08-25 Thread Benson Margulies (JIRA)
Benson Margulies created HTTPCORE-406: - Summary: Refactor some test code to be sharable with OSGi tests Key: HTTPCORE-406 URL: https://issues.apache.org/jira/browse/HTTPCORE-406 Project: HttpCompon

[jira] [Commented] (HTTPCORE-405) Add pax-exam tests to httpcore

2015-08-25 Thread Benson Margulies (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711076#comment-14711076 ] Benson Margulies commented on HTTPCORE-405: --- OK, I'll have another look. > Ad

[jira] [Commented] (HTTPCORE-404) Build fails with Java 1.8; unit test throws

2015-08-25 Thread Benson Margulies (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711072#comment-14711072 ] Benson Margulies commented on HTTPCORE-404: --- I'm perfectly mystified. I 'walke

[GitHub] httpclient pull request: URIBuilder extended for new method for em...

2015-08-25 Thread CanardSauvage
Github user CanardSauvage commented on the pull request: https://github.com/apache/httpclient/pull/35#issuecomment-134552803 Well, the pull request is against the trunk, so it would be applied to 5.0, or am I wrong? I don't think this is a specific use case. In my opinion the

[GitHub] httpclient pull request: URIBuilder extended for new method for em...

2015-08-25 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/35#issuecomment-134549644 Sebastian We cannot commit this patch to 4.5.x due to its changing the API signature of URIBuilder. There is unlikely to ever be a 4.6 series so this change can be

Re: [VOTE] Release HttpComponents Core 4.4.2 based on RC1

2015-08-25 Thread Oleg Kalnichevski
On Mon, 2015-08-24 at 22:13 -0700, Gary Gregory wrote: > Running 'mvn test', I get: > > testSSLHanskshakeProtocolMismatch2(org.apache.http.ssl.TestSSLContextBuilder) > Time elapsed: 0.031 sec <<< ERROR! > java.lang.Exception: Unexpected exception, > expected but > was > at java.net.Socke

Release called off; Re: [VOTE] Release HttpComponents Core 4.4.2 based on RC1

2015-08-25 Thread Oleg Kalnichevski
Folks Given the latest changes in the 4.4.x branch I am calling off RC1 and intend to prepare RC2 in a few days once things settle down a little. Oleg On Tue, 2015-08-25 at 08:36 +0530, Asankha C. Perera wrote: > On 08/23/2015 04:43 PM, Oleg Kalnichevski wrote: > > --

[jira] [Resolved] (HTTPCORE-405) Add pax-exam tests to httpcore

2015-08-25 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCORE-405. Resolution: Fixed Fix Version/s: 5.0-alpha1 4.4.2 Patch

[GitHub] httpcore pull request: Httpcore-405: osgi tests

2015-08-25 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/11#issuecomment-134546155 Patch committed to SVN trunk and 4.4.x branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] httpclient pull request: URIBuilder extended for new method for em...

2015-08-25 Thread CanardSauvage
Github user CanardSauvage commented on the pull request: https://github.com/apache/httpclient/pull/35#issuecomment-134542001 Because you would need to do an if with StringUtils.isEmpty for every parameter. We build a lot of urls for redirects and for links with a lot of parameters. If

Re: svn commit: r1697563 - /httpcomponents/contrib/httpcore/trunk/pom.xml

2015-08-25 Thread sebb
On 25 August 2015 at 06:57, wrote: > Author: ggregory > Date: Tue Aug 25 05:57:49 2015 > New Revision: 1697563 > > URL: http://svn.apache.org/r1697563 > Log: > Replace 4.0-alpha5-SNAPSHOT with 4.4.1. Log message does not agree with the change > Modified: > httpcomponents/contrib/httpcore/tr

[GitHub] httpclient pull request: URIBuilder extended for new method for em...

2015-08-25 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/httpclient/pull/35#issuecomment-134536829 Having parameters with blank values is perfectly fine. Why do we need another method for that where you can do a `StringUtils.isEmpty` for that? --- If your projec

[jira] [Resolved] (HTTPCORE-404) Build fails with Java 1.8; unit test throws

2015-08-25 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCORE-404. Resolution: Cannot Reproduce Benson I ran the test sequence through several millio

[GitHub] httpclient pull request: URIBuilder extended for new method for em...

2015-08-25 Thread CanardSauvage
GitHub user CanardSauvage opened a pull request: https://github.com/apache/httpclient/pull/35 URIBuilder extended for new method for empty values We are using the URIBuilder heavily across many projects. Before this we had our only implementation of an 'UrlBuilder' but we changed ev

[jira] [Commented] (HTTPCLIENT-1677) Update Apache Commons Codec from 1.9 to 1.10.

2015-08-25 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710870#comment-14710870 ] Michael Osipov commented on HTTPCLIENT-1677: Exactly! > Update Apache Co