Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/26#issuecomment-195153712
Thank you for the updated patch!
Committed revision 1734489.
Gary
---
If your project is set up for it, you can reply to this email and have your
Github user ok2c commented on the pull request:
https://github.com/apache/httpcore/pull/22#issuecomment-195036782
@dbantchovski Do you think you could also add a test case for this defect?
See src/test/java/org/apache/http/pool/TestConnPool.java
---
If your project is set up for it,
Github user faisal-hameed commented on the pull request:
https://github.com/apache/httpcore/pull/26#issuecomment-195012745
@garydgregory Done changes as you suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/26#issuecomment-194998971
I think that if you want to have this kind of change, I would like it
better if there was a code comment on the ctor that read something like "Do not
allow utility
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/25#issuecomment-194997788
Thank you for your patch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/25#issuecomment-194996238
Hi,
In the future, please run a build before you submit a patch. This patch
fails our checkstyle rules:
>
E:\vcs\svn\apache\httpcomponents\trunk\
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/24#issuecomment-194995325
Hi,
Thank you for your patch!
Committed revision 1734442.
Gary
---
If your project is set up for it, you can reply to this email and hav
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/23#issuecomment-194992409
Hi,
Thank you for your patch!
Committed revision 1734440.
Gary
---
If your project is set up for it, you can reply to this email and hav
GitHub user faisal-hameed opened a pull request:
https://github.com/apache/httpcore/pull/27
General code quality fix-1
This pull request is focused on resolving occurrences of Sonar rules
squid:S1854 - Dead stores should be removed.
squid:S1488 - Local Variables should not
GitHub user faisal-hameed opened a pull request:
https://github.com/apache/httpcore/pull/26
Code quality fix - Utility classes should not have public constructors.
This pull request is focused on resolving occurrences of Sonar rule
squid:S1118 - Utility classes should not have p
GitHub user faisal-hameed opened a pull request:
https://github.com/apache/httpcore/pull/25
Code quality fix - Collapsible "if" statements should be merged.
This pull request is focused on resolving occurrences of Sonar rule
squid:S1066 - Collapsible "if" statements should be me
GitHub user faisal-hameed opened a pull request:
https://github.com/apache/httpcore/pull/24
Code quality fix - Array designators "[]" should be on the type, not the
variable
This pull request is focused on resolving occurrences of Sonar rule
squid:S1197 - Array designators "[]"
GitHub user faisal-hameed opened a pull request:
https://github.com/apache/httpcore/pull/23
Code quality fix - Useless parentheses around expressions should be removed
to prevent any misunderstanding.
This pull request is focused on resolving occurrences of Sonar rule
squid:Use
GitHub user dbantchovski opened a pull request:
https://github.com/apache/httpcore/pull/22
Asymetric number of invocations of onLease/onRelease in conn pool
Hi colleagues,
I am investigating a connection leak problem in a library that, uses apache
httpclient. To track the i
[
https://issues.apache.org/jira/browse/HTTPASYNC-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189359#comment-15189359
]
Andrea Cosentino edited comment on HTTPASYNC-97 at 3/10/16 2:32 PM:
--
[
https://issues.apache.org/jira/browse/HTTPASYNC-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189359#comment-15189359
]
Andrea Cosentino commented on HTTPASYNC-97:
---
Hi [~olegk][~bimargul...@gmail.co
16 matches
Mail list logo
