[jira] [Commented] (HTTPCORE-466) Round out the SslContextBuilder by adding missing APIs

2017-05-12 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008897#comment-16008897 ] Gary Gregory commented on HTTPCORE-466: --- Please see Git branch {{dev/4.4.x/HTTPCOR

Re: Rounding out the SslContextBuilder

2017-05-12 Thread Gary Gregory
On Thu, May 11, 2017 at 12:25 AM, Oleg Kalnichevski wrote: > On Wed, 2017-05-10 at 23:31 -0700, Gary Gregory wrote: > > Hi All: > > > > We recently added the ability for the SslContextBuilder to accept a > > Provider. > > > > The other settings that we could pick up and that are currently hard- >

Re: trunk branch still in git

2017-05-12 Thread Gary Gregory
My bad, I was looking at the Git repo view in Eclipse, which was still tracking trunk. Gary On Fri, May 12, 2017 at 12:36 PM, Bindul Bhowmik wrote: > On Fri, May 12, 2017 at 12:53 PM, Gary Gregory > wrote: > > Hi all, > > > > It looks like we still have a trunk branch in our repo. > > Gary, >

Re: [ANNOUNCEMENT] HttpComponents Client 5.0 alpha2 released

2017-05-12 Thread Oleg Kalnichevski
On Fri, 2017-05-12 at 17:31 +0300, Filipp Gunbin wrote: > On 11/05/2017 14:54 +0200, Oleg Kalnichevski wrote: > > > The Apache HttpComponents project is pleased to announce 5.0-alpha2 > > release of HttpComponents Client.  > > > > ... > > Thanks for the release! > > `mvn clean install' in top-l

Re: trunk branch still in git

2017-05-12 Thread Bindul Bhowmik
On Fri, May 12, 2017 at 12:53 PM, Gary Gregory wrote: > Hi all, > > It looks like we still have a trunk branch in our repo. Gary, Which repository are you looking at? I don't see trunk on any of the following repos: - https://git-wip-us.apache.org/repos/asf?p=httpcomponents-core.git;a=heads - ht

trunk branch still in git

2017-05-12 Thread Gary Gregory
Hi all, It looks like we still have a trunk branch in our repo. It should be deleted now that we have master IMO. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition

Re: Do not commit to HttpClient SVN! HttpCore fully migrated to Git

2017-05-12 Thread Gary Gregory
Thank you for moving this through. Gary On May 12, 2017 5:07 AM, "Oleg Kalnichevski" wrote: > Folks > > Please refrain from committing to HttpClient SVN while it is being > migrated to Git. > > HttpCore has been fully migrated to Git. > > Happy hacking (on dev branches) > > Oleg > > ---

[GitHub] httpclient issue #74: WIP: OpenTracing integration

2017-05-12 Thread adriancole
Github user adriancole commented on the issue: https://github.com/apache/httpclient/pull/74 Oleg, thinking in general here.. I think one hook approach that would be nice to see in any instrumentation library is an interface like this.. Scope newScope(Attributes attribut

[GitHub] httpclient issue #76: Allow to add exec interceptor as the first and the las...

2017-05-12 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/76 @pavolloffay Please bear with me a few more days. I'll merge your changes as soon as we are done migrating to Git --- If your project is set up for it, you can reply to this email and have your repl

Re: [ANNOUNCEMENT] HttpComponents Client 5.0 alpha2 released

2017-05-12 Thread Filipp Gunbin
On 11/05/2017 14:54 +0200, Oleg Kalnichevski wrote: > The Apache HttpComponents project is pleased to announce 5.0-alpha2 > release of HttpComponents Client.  > > ... Thanks for the release! `mvn clean install' in top-level dir fails on httpclient5-fluent with javadoc error: [ERROR] /Users/fgu

[GitHub] httpclient issue #74: WIP: OpenTracing integration

2017-05-12 Thread adriancole
Github user adriancole commented on the issue: https://github.com/apache/httpclient/pull/74 > > @adriancole Adrain, feel to propose or, > better, to contribute "clean hooks into executors or other means to start > work" to HttpClient 5.0. Ther

[GitHub] httpclient issue #74: WIP: OpenTracing integration

2017-05-12 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/74 @adriancole Adrain, feel to propose or, better, to contribute "clean hooks into executors or other means to start work" to HttpClient 5.0. There we can still shape APIs as we deem fit. --- If your

[GitHub] httpclient issue #74: WIP: OpenTracing integration

2017-05-12 Thread adriancole
Github user adriancole commented on the issue: https://github.com/apache/httpclient/pull/74 hey, oleg. different project but same problem. Here's an example of instrumenting the async client w/ v4.3 (apologies I made no useful code comments explaining..) https://githu

[GitHub] httpclient pull request #74: WIP: OpenTracing integration

2017-05-12 Thread ok2c
Github user ok2c commented on a diff in the pull request: https://github.com/apache/httpclient/pull/74#discussion_r116229419 --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/TracingAsyncExec.java --- @@ -0,0 +1,80 @@ +package org.apache.hc.client5.http

[GitHub] httpclient pull request #74: WIP: OpenTracing integration

2017-05-12 Thread pavolloffay
Github user pavolloffay commented on a diff in the pull request: https://github.com/apache/httpclient/pull/74#discussion_r116227875 --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/TracingAsyncExec.java --- @@ -0,0 +1,80 @@ +package org.apache.hc.clien

[GitHub] httpclient issue #76: Allow to add exec interceptor as the first and the las...

2017-05-12 Thread pavolloffay
Github user pavolloffay commented on the issue: https://github.com/apache/httpclient/pull/76 Could it go in without tests? I don't know how the test should look like. To implement tests I need to access `NamedElementChain` which is constructed inside `HttpClientBuilder.build(

[GitHub] httpclient pull request #74: WIP: OpenTracing integration

2017-05-12 Thread ok2c
Github user ok2c commented on a diff in the pull request: https://github.com/apache/httpclient/pull/74#discussion_r116219416 --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/TracingAsyncExec.java --- @@ -0,0 +1,80 @@ +package org.apache.hc.client5.http

[GitHub] httpclient pull request #74: WIP: OpenTracing integration

2017-05-12 Thread pavolloffay
Github user pavolloffay commented on a diff in the pull request: https://github.com/apache/httpclient/pull/74#discussion_r116216114 --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/TracingAsyncExec.java --- @@ -0,0 +1,80 @@ +package org.apache.hc.clien

Do not commit to HttpClient SVN! HttpCore fully migrated to Git

2017-05-12 Thread Oleg Kalnichevski
Folks Please refrain from committing to HttpClient SVN while it is being migrated to Git.  HttpCore has been fully migrated to Git. Happy hacking (on dev branches) Oleg - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org F