[jira] [Commented] (HTTPCLIENT-2105) HttpClient5 makes post call with no body after 307 redirect

2020-08-05 Thread Randymo (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171776#comment-17171776 ] Randymo commented on HTTPCLIENT-2105: - I am using the SimpleHttpRequest, so it is a SimpleBody

[jira] [Commented] (HTTPCLIENT-2105) HttpClient5 makes post call with no body after 307 redirect

2020-08-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171767#comment-17171767 ] Michael Osipov commented on HTTPCLIENT-2105: Which {{HttpEntity}} do you use? >

[jira] [Created] (HTTPCLIENT-2105) HttpClient5 makes post call with no body after 307 redirect

2020-08-05 Thread Randymo (Jira)
Randymo created HTTPCLIENT-2105: --- Summary: HttpClient5 makes post call with no body after 307 redirect Key: HTTPCLIENT-2105 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2105 Project:

[GitHub] [httpcomponents-core] michael-o commented on pull request #211: HTTPCORE-642: Cleaner ConnectionFactory builder ContentLengthStrategy names

2020-08-05 Thread GitBox
michael-o commented on pull request #211: URL: https://github.com/apache/httpcomponents-core/pull/211#issuecomment-669383867 Very nice, thank you! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [httpcomponents-core] carterkozak commented on pull request #211: HTTPCORE-642: Cleaner ConnectionFactory builder ContentLengthStrategy names

2020-08-05 Thread GitBox
carterkozak commented on pull request #211: URL: https://github.com/apache/httpcomponents-core/pull/211#issuecomment-669325843 Thanks! This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HTTPCORE-642) Implement ConnectionFactory fluent builders

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171639#comment-17171639 ] ASF subversion and git services commented on HTTPCORE-642: -- Commit

[GitHub] [httpcomponents-core] ok2c commented on pull request #211: HTTPCORE-642: Cleaner ConnectionFactory builder ContentLengthStrategy names

2020-08-05 Thread GitBox
ok2c commented on pull request #211: URL: https://github.com/apache/httpcomponents-core/pull/211#issuecomment-669325098 @carterkozak @michael-o Folded into 68812751e438dc7a52e64cf5d5078cd23f3421d7 This is an automated

[jira] [Commented] (HTTPCORE-639) Add a configurable ResponseOutOfOrder strategy for DefaultBHttpClientConnection

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171641#comment-17171641 ] ASF subversion and git services commented on HTTPCORE-639: -- Commit

[GitHub] [httpcomponents-core] ok2c closed pull request #211: HTTPCORE-642: Cleaner ConnectionFactory builder ContentLengthStrategy names

2020-08-05 Thread GitBox
ok2c closed pull request #211: URL: https://github.com/apache/httpcomponents-core/pull/211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HTTPCORE-643) Add zero content-length to PUT and POST requests with no entity

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171640#comment-17171640 ] ASF subversion and git services commented on HTTPCORE-643: -- Commit

[GitHub] [httpcomponents-core] michael-o commented on pull request #212: Enable IT for H2 Protocol Negotiation

2020-08-05 Thread GitBox
michael-o commented on pull request #212: URL: https://github.com/apache/httpcomponents-core/pull/212#issuecomment-669194004 Closin per discussion. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [httpcomponents-core] michael-o closed pull request #212: Enable IT for H2 Protocol Negotiation

2020-08-05 Thread GitBox
michael-o closed pull request #212: URL: https://github.com/apache/httpcomponents-core/pull/212 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [httpcomponents-core] michael-o edited a comment on pull request #212: Enable IT for H2 Protocol Negotiation

2020-08-05 Thread GitBox
michael-o edited a comment on pull request #212: URL: https://github.com/apache/httpcomponents-core/pull/212#issuecomment-669194004 Closing as per discussion. This is an automated message from the Apache Git Service. To

[jira] [Comment Edited] (HTTPCORE-644) High CPU usage noticed for SSLIOSession.close() after JDK upgrade

2020-08-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171509#comment-17171509 ] Oleg Kalnichevski edited comment on HTTPCORE-644 at 8/5/20, 1:57 PM:

[jira] [Commented] (HTTPCORE-644) High CPU usage noticed for SSLIOSession.close() after JDK upgrade

2020-08-05 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171509#comment-17171509 ] Oleg Kalnichevski commented on HTTPCORE-644: [~arunans23] I was unable to reproduce the

[GitHub] [httpcomponents-core] michael-o commented on pull request #211: HTTPCORE-642: Cleaner ConnectionFactory builder ContentLengthStrategy names

2020-08-05 Thread GitBox
michael-o commented on pull request #211: URL: https://github.com/apache/httpcomponents-core/pull/211#issuecomment-669191490 @ok2c Agreed. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [httpcomponents-core] carterkozak commented on a change in pull request #212: Enable IT for H2 Protocol Negotiation

2020-08-05 Thread GitBox
carterkozak commented on a change in pull request #212: URL: https://github.com/apache/httpcomponents-core/pull/212#discussion_r465716546 ## File path: httpcore5-testing/src/test/java/org/apache/hc/core5/testing/nio/H2ProtocolNegotiationTest.java ## @@ -233,7 +233,7 @@

[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #212: Enable IT for H2 Protocol Negotiation

2020-08-05 Thread GitBox
ok2c commented on a change in pull request #212: URL: https://github.com/apache/httpcomponents-core/pull/212#discussion_r465716829 ## File path: httpcore5-testing/src/test/java/org/apache/hc/core5/testing/nio/H2ProtocolNegotiationTest.java ## @@ -233,7 +233,7 @@ public void

[GitHub] [httpcomponents-core] ok2c commented on pull request #211: HTTPCORE-642: Cleaner ConnectionFactory builder ContentLengthStrategy names

2020-08-05 Thread GitBox
ok2c commented on pull request #211: URL: https://github.com/apache/httpcomponents-core/pull/211#issuecomment-669183911 @carterkozak @michael-o I will fold this change-set into 503970518 This is an automated message from

[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #212: Enable IT for H2 Protocol Negotiation

2020-08-05 Thread GitBox
michael-o commented on a change in pull request #212: URL: https://github.com/apache/httpcomponents-core/pull/212#discussion_r465710354 ## File path: httpcore5-testing/src/test/java/org/apache/hc/core5/testing/nio/H2ProtocolNegotiationTest.java ## @@ -233,7 +233,7 @@ public

[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #212: Enable IT for H2 Protocol Negotiation

2020-08-05 Thread GitBox
michael-o commented on a change in pull request #212: URL: https://github.com/apache/httpcomponents-core/pull/212#discussion_r465706546 ## File path: httpcore5-testing/src/test/java/org/apache/hc/core5/testing/nio/H2ProtocolNegotiationTest.java ## @@ -233,7 +233,7 @@ public

[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #212: Enable IT for H2 Protocol Negotiation

2020-08-05 Thread GitBox
michael-o commented on a change in pull request #212: URL: https://github.com/apache/httpcomponents-core/pull/212#discussion_r465706546 ## File path: httpcore5-testing/src/test/java/org/apache/hc/core5/testing/nio/H2ProtocolNegotiationTest.java ## @@ -233,7 +233,7 @@ public

[GitHub] [httpcomponents-core] carterkozak commented on a change in pull request #212: Enable IT for H2 Protocol Negotiation

2020-08-05 Thread GitBox
carterkozak commented on a change in pull request #212: URL: https://github.com/apache/httpcomponents-core/pull/212#discussion_r465701522 ## File path: httpcore5-testing/src/test/java/org/apache/hc/core5/testing/nio/H2ProtocolNegotiationTest.java ## @@ -233,7 +233,7 @@

[GitHub] [httpcomponents-core] michael-o opened a new pull request #212: Enable IT for H2 Protocol Negotiation

2020-08-05 Thread GitBox
michael-o opened a new pull request #212: URL: https://github.com/apache/httpcomponents-core/pull/212 Since TLS 1.3 and/or APLN is now available in Java 8 we can enable this and avoid the failure on Java 8. This is an

[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+

2020-08-05 Thread GitBox
michael-o commented on pull request #207: URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669152479 Here you go: https://home.apache.org/~michaelo/issues/early-response/try-6/20b1cc8fd8e1050bbd3957b21697138e074dd24d/ Windows 10: My work laptop, connected

[GitHub] [httpcomponents-core] carterkozak commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+

2020-08-05 Thread GitBox
carterkozak commented on pull request #207: URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669143416 I'd appreciate the logs if you don't mind sharing them :-) This is an automated message from the

[GitHub] [httpcomponents-core] michael-o edited a comment on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+

2020-08-05 Thread GitBox
michael-o edited a comment on pull request #207: URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669142919 The test setup is basically a loop which uploads a ZIP file (around 7 MB) to a Tomcat 8.5.5x instance. The target URL is auth protected and Tomcat detects

[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+

2020-08-05 Thread GitBox
michael-o commented on pull request #207: URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669142919 The test setup is basically a loop which uploads a ZIP file (around 7 MB) to a Tomcat instance. The target URL is auth protected and Tomcat detects that really

[GitHub] [httpcomponents-core] carterkozak commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+

2020-08-05 Thread GitBox
carterkozak commented on pull request #207: URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669139317 That's odd. I don't expect any change in behavior using TLS, however plain http response detection hasn't worked for me on linux on 13+. I'm setting up a Windows

[GitHub] [httpcomponents-core] carterkozak commented on pull request #210: HTTPCORE-639: Partially revert expensive early-response checks

2020-08-05 Thread GitBox
carterkozak commented on pull request #210: URL: https://github.com/apache/httpcomponents-core/pull/210#issuecomment-669135762 Thanks, I'm closing this because a3870ef2808cd78c9c3d849df6ee56b2ef8a4f95 has been committed.

[GitHub] [httpcomponents-core] carterkozak closed pull request #210: HTTPCORE-639: Partially revert expensive early-response checks

2020-08-05 Thread GitBox
carterkozak closed pull request #210: URL: https://github.com/apache/httpcomponents-core/pull/210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [httpcomponents-core] carterkozak commented on a change in pull request #211: HTTPCORE-642: Cleaner ConnectionFactory builder ContentLengthStrategy names

2020-08-05 Thread GitBox
carterkozak commented on a change in pull request #211: URL: https://github.com/apache/httpcomponents-core/pull/211#discussion_r465654563 ## File path: httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnectionFactory.java ## @@ -140,12 +140,12 @@

[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+

2020-08-05 Thread GitBox
michael-o commented on pull request #207: URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669091237 Moved the same code to anther box with 14.0.2+12-1 on FreeBSD 12-STABLE with the same backend on OpenSSL 1.1.1g, TLS 1.3 is negotiated. What now?

[jira] [Commented] (HTTPCORE-642) Implement ConnectionFactory fluent builders

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171371#comment-17171371 ] ASF subversion and git services commented on HTTPCORE-642: -- Commit

[jira] [Commented] (HTTPCORE-643) Add zero content-length to PUT and POST requests with no entity

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171372#comment-17171372 ] ASF subversion and git services commented on HTTPCORE-643: -- Commit

[jira] [Commented] (HTTPCORE-639) Add a configurable ResponseOutOfOrder strategy for DefaultBHttpClientConnection

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171373#comment-17171373 ] ASF subversion and git services commented on HTTPCORE-639: -- Commit

[jira] [Commented] (HTTPCORE-628) URIBuilder:: query parameters are encoded differently compared to java.lang.URI

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171369#comment-17171369 ] ASF subversion and git services commented on HTTPCORE-628: -- Commit

[jira] [Commented] (HTTPCORE-627) URIBuilder::Adding query parameters result in removing the scheme specific part of an URI

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171370#comment-17171370 ] ASF subversion and git services commented on HTTPCORE-627: -- Commit

[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+

2020-08-05 Thread GitBox
michael-o commented on pull request #207: URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669077627 Just tried off 1ca04d66a w/o your change first on Windows 10 with Zulu 13.0.4 commercial version. The backend is running Apache Tomcat 8.5.x on OpenJDK 8 on

[jira] [Commented] (HTTPCORE-639) Add a configurable ResponseOutOfOrder strategy for DefaultBHttpClientConnection

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171354#comment-17171354 ] ASF subversion and git services commented on HTTPCORE-639: -- Commit

[GitHub] [httpcomponents-core] michael-o commented on pull request #207: HTTPCORE-640: http response out of order checks work on java 13+

2020-08-05 Thread GitBox
michael-o commented on pull request #207: URL: https://github.com/apache/httpcomponents-core/pull/207#issuecomment-669069746 I am looking into this right now. This is an automated message from the Apache Git Service. To

[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #211: HTTPCORE-642: Cleaner ConnectionFactory builder ContentLengthStrategy names

2020-08-05 Thread GitBox
michael-o commented on a change in pull request #211: URL: https://github.com/apache/httpcomponents-core/pull/211#discussion_r465574464 ## File path: httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnectionFactory.java ## @@ -140,12 +140,12 @@

[GitHub] [httpcomponents-core] michael-o commented on pull request #206: HTTPCORE-639: Configurable ResponseOutOfOrderStrategy

2020-08-05 Thread GitBox
michael-o commented on pull request #206: URL: https://github.com/apache/httpcomponents-core/pull/206#issuecomment-669068640 > > > > This would bascially mean that we will end up with a halfhearted solution 5.0.x, unusable for TLS. > > This is a good case of something

[jira] [Commented] (HTTPCORE-639) Add a configurable ResponseOutOfOrder strategy for DefaultBHttpClientConnection

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171350#comment-17171350 ] ASF subversion and git services commented on HTTPCORE-639: -- Commit

[jira] [Commented] (HTTPCORE-643) Add zero content-length to PUT and POST requests with no entity

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171349#comment-17171349 ] ASF subversion and git services commented on HTTPCORE-643: -- Commit

[jira] [Commented] (HTTPCORE-642) Implement ConnectionFactory fluent builders

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171348#comment-17171348 ] ASF subversion and git services commented on HTTPCORE-642: -- Commit

[GitHub] [httpcomponents-core] ok2c commented on pull request #206: HTTPCORE-639: Configurable ResponseOutOfOrderStrategy

2020-08-05 Thread GitBox
ok2c commented on pull request #206: URL: https://github.com/apache/httpcomponents-core/pull/206#issuecomment-669061168 > This would bascially mean that we will end up with a halfhearted solution 5.0.x, unusable for TLS. This is a good case of something working partially being

[GitHub] [httpcomponents-core] michael-o commented on pull request #206: HTTPCORE-639: Configurable ResponseOutOfOrderStrategy

2020-08-05 Thread GitBox
michael-o commented on pull request #206: URL: https://github.com/apache/httpcomponents-core/pull/206#issuecomment-669055108 Merged, thank you very much! This is an automated message from the Apache Git Service. To respond

[GitHub] [httpcomponents-core] michael-o closed pull request #206: HTTPCORE-639: Configurable ResponseOutOfOrderStrategy

2020-08-05 Thread GitBox
michael-o closed pull request #206: URL: https://github.com/apache/httpcomponents-core/pull/206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Closed] (HTTPCORE-639) Add a configurable ResponseOutOfOrder strategy for DefaultBHttpClientConnection

2020-08-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed HTTPCORE-639. --- Resolution: Fixed > Add a configurable ResponseOutOfOrder strategy for >

[jira] [Commented] (HTTPCORE-639) Add a configurable ResponseOutOfOrder strategy for DefaultBHttpClientConnection

2020-08-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171336#comment-17171336 ] ASF subversion and git services commented on HTTPCORE-639: -- Commit

[GitHub] [httpcomponents-core] michael-o commented on pull request #206: HTTPCORE-639: Configurable ResponseOutOfOrderStrategy

2020-08-05 Thread GitBox
michael-o commented on pull request #206: URL: https://github.com/apache/httpcomponents-core/pull/206#issuecomment-669053390 I have updated all 8, 11, and 14 on Windows. All ITs pass now. I will continue merging. This is

[GitHub] [httpcomponents-core] michael-o commented on pull request #206: HTTPCORE-639: Configurable ResponseOutOfOrderStrategy

2020-08-05 Thread GitBox
michael-o commented on pull request #206: URL: https://github.com/apache/httpcomponents-core/pull/206#issuecomment-669001858 I see the following on Windows: ``` [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.289 s <<< FAILURE! - in

[jira] [Assigned] (HTTPCORE-639) Add a configurable ResponseOutOfOrder strategy for DefaultBHttpClientConnection

2020-08-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned HTTPCORE-639: --- Assignee: Michael Osipov > Add a configurable ResponseOutOfOrder strategy for >

[jira] [Updated] (HTTPCORE-639) Add a configurable ResponseOutOfOrder strategy for DefaultBHttpClientConnection

2020-08-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated HTTPCORE-639: Summary: Add a configurable ResponseOutOfOrder strategy for DefaultBHttpClientConnection