[GitHub] [httpcomponents-client] arturobernalg commented on a change in pull request #328: Convert QOP constants into an enum.

arturobernalg commented on a change in pull request #328: URL: https://github.com/apache/httpcomponents-client/pull/328#discussion_r752672179 ## File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/DigestScheme.java ## @@ -100,10 +100,12 @@ 'e',

[GitHub] [httpcomponents-client] michael-o commented on a change in pull request #328: Convert QOP constants into an enum.

michael-o commented on a change in pull request #328: URL: https://github.com/apache/httpcomponents-client/pull/328#discussion_r752666735 ## File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/DigestScheme.java ## @@ -100,10 +100,12 @@ 'e', 'f'

[GitHub] [httpcomponents-client] arturobernalg commented on pull request #328: Convert QOP constants into an enum.

arturobernalg commented on pull request #328: URL: https://github.com/apache/httpcomponents-client/pull/328#issuecomment-973309952 > If at all the class should be called QualityOfProtection and the QOP_ prefix is redundant. HI @michael-o you're right. changed. TY -- Th

[GitHub] [httpcomponents-client] arturobernalg commented on a change in pull request #326: Use Args for argument check.

arturobernalg commented on a change in pull request #326: URL: https://github.com/apache/httpcomponents-client/pull/326#discussion_r752658689 ## File path: httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializerTestUtils.java ##

[GitHub] [httpcomponents-core] arturobernalg opened a new pull request #332: Do not explicitly declare runtime exceptions.

arturobernalg opened a new pull request #332: URL: https://github.com/apache/httpcomponents-core/pull/332 Because that is a "runtime" exception and we don't need to declare it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HTTPCLIENT-2186) Migrate Test to Unit 5

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446110#comment-17446110 ] Arturo Bernal commented on HTTPCLIENT-2186: --- Hi. The first approach of th

[GitHub] [httpcomponents-client] arturobernalg opened a new pull request #327: HTTPCLIENT-2186 - Migrate Test to Unit 5.

arturobernalg opened a new pull request #327: URL: https://github.com/apache/httpcomponents-client/pull/327 The first approach of the change to Junit 5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to