[jira] [Commented] (HTTPCLIENT-2205) Ability to set SSL Context and hence Keystore for every request

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494778#comment-17494778 ] Ryan Schmitt commented on HTTPCLIENT-2205: -- We also have a use case like th

[GitHub] [httpcomponents-client] ok2c commented on pull request #351: Async HttpClient builders to support custom IOSessionListener

ok2c commented on pull request #351: URL: https://github.com/apache/httpcomponents-client/pull/351#issuecomment-1044945590 @cda007 This has nothing to do with git. This is straight Maven. `mvn clean verify` has got to pass for you locally with your changes. Style rules like no trailing bl

[GitHub] [httpcomponents-client] cda007 commented on pull request #351: Async HttpClient builders to support custom IOSessionListener

cda007 commented on pull request #351: URL: https://github.com/apache/httpcomponents-client/pull/351#issuecomment-1044914487 Hi Oleg, Sorry for this. As I told you I am not familiar with this process and with git. Is there any specific pre-commit hook that would avoid to commit code

[GitHub] [httpcomponents-client] ok2c commented on pull request #351: Async HttpClient builders to support custom IOSessionListener

ok2c commented on pull request #351: URL: https://github.com/apache/httpcomponents-client/pull/351#issuecomment-1044872336 @cda007 The build still fails. There are still trailing blanks left. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [httpcomponents-client] ok2c commented on pull request #351: Async HttpClient builders to support custom IOSessionListener

ok2c commented on pull request #351: URL: https://github.com/apache/httpcomponents-client/pull/351#issuecomment-1044786007 @cda007 Looks good to me. Please fix the check-style violations (trailing blanks) and I will merge your changes. -- This is an automated message from the Apache Git

[GitHub] [httpcomponents-client] cda007 commented on a change in pull request #351: Async HttpClient builders to support custom IOSessionListener

cda007 commented on a change in pull request #351: URL: https://github.com/apache/httpcomponents-client/pull/351#discussion_r810097731 ## File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/HttpAsyncClientBuilder.java ## @@ -318,7 +320,15 @@ public fina

[jira] [Commented] (HTTPCLIENT-2205) Ability to set SSL Context and hence Keystore for every request

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494591#comment-17494591 ] Logan commented on HTTPCLIENT-2205: --- > If you are not willing to build your own co

[jira] [Commented] (HTTPCLIENT-2205) Ability to set SSL Context and hence Keystore for every request

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494561#comment-17494561 ] Oleg Kalnichevski commented on HTTPCLIENT-2205: --- [~Logan007] If you ar

[GitHub] [httpcomponents-client] ok2c commented on a change in pull request #351: Update HttpAsyncClientBuilder.java

ok2c commented on a change in pull request #351: URL: https://github.com/apache/httpcomponents-client/pull/351#discussion_r809921984 ## File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/HttpAsyncClientBuilder.java ## @@ -318,7 +320,15 @@ public final

[GitHub] [httpcomponents-client] SmallerCoder commented on pull request #351: Update HttpAsyncClientBuilder.java

SmallerCoder commented on pull request #351: URL: https://github.com/apache/httpcomponents-client/pull/351#issuecomment-1044298742 邮件已收到！我会尽快阅读！谢谢！ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [httpcomponents-client] cda007 opened a new pull request #351: Update HttpAsyncClientBuilder.java

cda007 opened a new pull request #351: URL: https://github.com/apache/httpcomponents-client/pull/351 Add the option to set an IOSessionListener on HttpAsyncClientBuilder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use