Robert Wang created HTTPCLIENT-2206:
---
Summary: fluent: Response#saveContent(File) does not dispose
response upon throwing
Key: HTTPCLIENT-2206
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2206
schlosna commented on pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#issuecomment-1051074768
Updated to use switch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
schlosna edited a comment on pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#issuecomment-1051045250
@michael-o I pulled out a `PrefixedIncrementingId` class to enable reuse
across `Exchange`, `PoolingHttpClientConnectionManager`,
carterkozak commented on pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#issuecomment-1051060746
hard-coding length 10 and using the switch would be nice, but I defer to
your judgement
--
This is an automated message from the Apache Git Service.
To
schlosna commented on a change in pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#discussion_r814961372
##
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java
##
@@ -45,7 +45,29 @@ public static long
schlosna commented on pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#issuecomment-1051045250
@michael-o I pulled out an `IncrementingId` class to enable reuse across
`Exchange`, `PoolingHttpClientConnectionManager`,
`PoolingAsyncClientConnectionManager`.
carterkozak commented on a change in pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#discussion_r814919595
##
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java
##
@@ -45,7 +45,29 @@ public static long
schlosna commented on a change in pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#discussion_r814902188
##
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java
##
@@ -45,7 +45,29 @@ public static long
ok2c commented on a change in pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#discussion_r814901897
##
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java
##
@@ -45,7 +45,29 @@ public static long
carterkozak commented on a change in pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#discussion_r814900201
##
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java
##
@@ -45,7 +45,29 @@ public static long
carterkozak commented on a change in pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#discussion_r814900201
##
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java
##
@@ -45,7 +45,29 @@ public static long
ok2c commented on pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#issuecomment-1050990006
@schlosna Awesome! Could you please fix style-check violations, though?
--
This is an automated message from the Apache Git Service.
To respond to the message,
michael-o commented on a change in pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#discussion_r814892020
##
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java
##
@@ -45,7 +45,29 @@ public static long
carterkozak commented on a change in pull request #352:
URL:
https://github.com/apache/httpcomponents-client/pull/352#discussion_r814890829
##
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/ExecSupport.java
##
@@ -45,7 +45,29 @@ public static long
schlosna opened a new pull request #352:
URL: https://github.com/apache/httpcomponents-client/pull/352
While analyzing some JFR profiles from a service utilizing a high volume of
async HTTP client requests, I noticed one of the top memory allocations of
`java.text.DecimalFormatSymbols`
[
https://issues.apache.org/jira/browse/HTTPCORE-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498154#comment-17498154
]
Oleg Kalnichevski commented on HTTPCORE-708:
> It looks like race condition to me, let's
[
https://issues.apache.org/jira/browse/HTTPCORE-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498148#comment-17498148
]
Lubos Husivarga commented on HTTPCORE-708:
--
Thank you [~olegk] It looks like race condition
[
https://issues.apache.org/jira/browse/HTTPCORE-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498073#comment-17498073
]
Oleg Kalnichevski commented on HTTPCORE-708:
[~lhusivarga] It turns out to be a really
18 matches
Mail list logo
