[
https://issues.apache.org/jira/browse/HTTPCLIENT-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535873#comment-17535873
]
Oleg Kalnichevski commented on HTTPCLIENT-2215:
---
[~yinwoods] I suppose you have given
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yinwoods closed HTTPCLIENT-2215.
Resolution: Not A Problem
It's not elegant to implement br decompression with new dependency
yinwoods closed pull request #363: add br decompression support
URL: https://github.com/apache/httpcomponents-client/pull/363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
yinwoods commented on PR #363:
URL:
https://github.com/apache/httpcomponents-client/pull/363#issuecomment-1124502419
OK, make sense to me. Apache Commons Compress also depends on this dec
dependency, I will close this PR.
--
This is an automated message from the Apache Git Service.
To
garydgregory commented on PR #363:
URL:
https://github.com/apache/httpcomponents-client/pull/363#issuecomment-1124487913
I do not think we want a direct dependency or hard wired support for one of
many compression formats.
You might be better off with your app depending on Apache
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535833#comment-17535833
]
yinwoods commented on HTTPCLIENT-2215:
--
Hi,I made a PR on github:
niranjanghule commented on PR #362:
URL:
https://github.com/apache/httpcomponents-client/pull/362#issuecomment-1123577838
Thanks! I'll avoid single line commits next time onwards.
Thanks and Regards
Niranjan Ghule
On Wed, 11 May 2022, 3:27 pm Oleg Kalnichevski,
ok2c merged PR #362:
URL: https://github.com/apache/httpcomponents-client/pull/362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c commented on PR #362:
URL:
https://github.com/apache/httpcomponents-client/pull/362#issuecomment-1123475575
@niranjanghule I am not a big fan of one-line refactoring commits. I will
make an exception in this case, though
--
This is an automated message from the Apache Git Service.