[jira] [Commented] (HTTPCLIENT-2215) support BRInputStreamFactory for handling br coded response

2022-05-11 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535873#comment-17535873 ] Oleg Kalnichevski commented on HTTPCLIENT-2215: --- [~yinwoods] I suppose you have given

[jira] [Closed] (HTTPCLIENT-2215) support BRInputStreamFactory for handling br coded response

2022-05-11 Thread yinwoods (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yinwoods closed HTTPCLIENT-2215. Resolution: Not A Problem It's not elegant to implement br decompression with new dependency

[GitHub] [httpcomponents-client] yinwoods closed pull request #363: add br decompression support

2022-05-11 Thread GitBox
yinwoods closed pull request #363: add br decompression support URL: https://github.com/apache/httpcomponents-client/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [httpcomponents-client] yinwoods commented on pull request #363: add br decompression support

2022-05-11 Thread GitBox
yinwoods commented on PR #363: URL: https://github.com/apache/httpcomponents-client/pull/363#issuecomment-1124502419 OK, make sense to me. Apache Commons Compress also depends on this dec dependency, I will close this PR. -- This is an automated message from the Apache Git Service. To

[GitHub] [httpcomponents-client] garydgregory commented on pull request #363: add br decompression support

2022-05-11 Thread GitBox
garydgregory commented on PR #363: URL: https://github.com/apache/httpcomponents-client/pull/363#issuecomment-1124487913 I do not think we want a direct dependency or hard wired support for one of many compression formats. You might be better off with your app depending on Apache

[jira] [Commented] (HTTPCLIENT-2215) support BRInputStreamFactory for handling br coded response

2022-05-11 Thread yinwoods (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535833#comment-17535833 ] yinwoods commented on HTTPCLIENT-2215: -- Hi,I made a PR on github:

[GitHub] [httpcomponents-client] niranjanghule commented on pull request #362: Refactor testcase

2022-05-11 Thread GitBox
niranjanghule commented on PR #362: URL: https://github.com/apache/httpcomponents-client/pull/362#issuecomment-1123577838 Thanks! I'll avoid single line commits next time onwards. Thanks and Regards Niranjan Ghule On Wed, 11 May 2022, 3:27 pm Oleg Kalnichevski,

[GitHub] [httpcomponents-client] ok2c merged pull request #362: Refactor testcase

2022-05-11 Thread GitBox
ok2c merged PR #362: URL: https://github.com/apache/httpcomponents-client/pull/362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [httpcomponents-client] ok2c commented on pull request #362: Refactor testcase

2022-05-11 Thread GitBox
ok2c commented on PR #362: URL: https://github.com/apache/httpcomponents-client/pull/362#issuecomment-1123475575 @niranjanghule I am not a big fan of one-line refactoring commits. I will make an exception in this case, though -- This is an automated message from the Apache Git Service.