[GitHub] [httpcomponents-core] ok2c commented on pull request #350: HTTPCLIENT-2185 Add support for IDNA 2008 (RFC 5891)

2022-06-18 Thread GitBox
ok2c commented on PR #350: URL: https://github.com/apache/httpcomponents-core/pull/350#issuecomment-1159473705 > Is it worth caching the encoder? No, it is not. The idea is to not use an encoder at all. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [httpcomponents-core] ok2c merged pull request #348: Bump log4j-core from 2.17.0 to 2.17.1

2022-06-18 Thread GitBox
ok2c merged PR #348: URL: https://github.com/apache/httpcomponents-core/pull/348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

[GitHub] [httpcomponents-core] garydgregory commented on pull request #350: HTTPCLIENT-2185 Add support for IDNA 2008 (RFC 5891)

2022-06-18 Thread GitBox
garydgregory commented on PR #350: URL: https://github.com/apache/httpcomponents-core/pull/350#issuecomment-1159453526 Is it worth caching the encoder? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #350: HTTPCLIENT-2185 Add support for IDNA 2008 (RFC 5891)

2022-06-18 Thread GitBox
ok2c commented on code in PR #350: URL: https://github.com/apache/httpcomponents-core/pull/350#discussion_r900815085 ## httpcore5/src/main/java/org/apache/hc/core5/net/Host.java: ## @@ -71,7 +73,10 @@ static Host parse(final CharSequence s, final Tokenizer.Cursor cursor) throw

[GitHub] [httpcomponents-client] ok2c merged pull request #367: Bump github/codeql-action from 1 to 2

2022-06-18 Thread GitBox
ok2c merged PR #367: URL: https://github.com/apache/httpcomponents-client/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

[GitHub] [httpcomponents-client] ok2c merged pull request #368: Bump actions/checkout from 2 to 3

2022-06-18 Thread GitBox
ok2c merged PR #368: URL: https://github.com/apache/httpcomponents-client/pull/368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.ap

[jira] [Comment Edited] (HTTPCLIENT-2185) Add support for IDNA 2008 (RFC 5891)

2022-06-18 Thread asuka amamiya (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508112#comment-17508112 ] asuka amamiya edited comment on HTTPCLIENT-2185 at 6/18/22 10:34 AM: -

[GitHub] [httpcomponents-core] hanasakari opened a new pull request, #350: HTTPCLIENT-2185 Add support for IDNA 2008 (RFC 5891)

2022-06-18 Thread GitBox
hanasakari opened a new pull request, #350: URL: https://github.com/apache/httpcomponents-core/pull/350 support IDNA 2008 (RFC 5896) for [Add support for IDNA 2008 (RFC 5891)](https://issues.apache.org/jira/browse/HTTPCLIENT-2185?jql=project%20in%20(HTTPCLIENT%2C%20HTTPCORE)%20AND%20status%