[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #429: Improve HttpByteArrayCacheEntrySerializer class by adding new methods and enhancing performance.

2023-03-30 Thread via GitHub
ok2c commented on code in PR #429: URL: https://github.com/apache/httpcomponents-client/pull/429#discussion_r1154065239 ## httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializer.java: ## @@ -42,36 +44,68 @@ import org.apache.hc.

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #429: Improve HttpByteArrayCacheEntrySerializer class by adding new methods and enhancing performance.

2023-03-30 Thread via GitHub
michael-o commented on code in PR #429: URL: https://github.com/apache/httpcomponents-client/pull/429#discussion_r1154062956 ## httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializer.java: ## @@ -42,36 +44,68 @@ import org.apach

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #429: Improve HttpByteArrayCacheEntrySerializer class by adding new methods and enhancing performance.

2023-03-30 Thread via GitHub
ok2c commented on code in PR #429: URL: https://github.com/apache/httpcomponents-client/pull/429#discussion_r1154034009 ## httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/HttpByteArrayCacheEntrySerializer.java: ## @@ -42,36 +44,68 @@ import org.apache.hc.

[GitHub] [httpcomponents-core] ok2c commented on pull request #399: HTTPCORE-737: Add maven.compiler.release if build jdk >= 9

2023-03-30 Thread via GitHub
ok2c commented on PR #399: URL: https://github.com/apache/httpcomponents-core/pull/399#issuecomment-1491305977 > Is this a documented behavior, or a bug in Maven? I can't understand how this behavior could ever be correct. @rschmitt I am not sure. The behavior looks wrong to me but f

[GitHub] [httpcomponents-core] rschmitt commented on pull request #399: HTTPCORE-737: Add maven.compiler.release if build jdk >= 9

2023-03-30 Thread via GitHub
rschmitt commented on PR #399: URL: https://github.com/apache/httpcomponents-core/pull/399#issuecomment-1491262565 > The problem is that the activation gets triggered for the host JDK and not that used to compile the artifacts. Is this a documented behavior, or a bug in Maven? I can'

[jira] [Commented] (HTTPCLIENT-2268) How do you cancel async request?

2023-03-30 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706973#comment-17706973 ] Oleg Kalnichevski commented on HTTPCLIENT-2268: --- [~patrickjamesbarry]

[jira] [Resolved] (HTTPCLIENT-2268) How do you cancel async request?

2023-03-30 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-2268. --- Resolution: Information Provided > How do you cancel async request? > --

[jira] [Commented] (HTTPCORE-737) HttpClient not working with Java 8 runtime

2023-03-30 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706972#comment-17706972 ] Oleg Kalnichevski commented on HTTPCORE-737: [~akatkere] I would not want t

[jira] [Comment Edited] (HTTPCLIENT-2267) Connect called before Interceptors are invoked

2023-03-30 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706969#comment-17706969 ] Oleg Kalnichevski edited comment on HTTPCLIENT-2267 at 3/30/23 4:59 PM: --

[jira] [Commented] (HTTPCLIENT-2267) Connect called before Interceptors are invoked

2023-03-30 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706969#comment-17706969 ] Oleg Kalnichevski commented on HTTPCLIENT-2267: --- [~patrickjamesbarry]

[jira] [Commented] (HTTPCORE-737) HttpClient not working with Java 8 runtime

2023-03-30 Thread Arun Katkere (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706935#comment-17706935 ] Arun Katkere commented on HTTPCORE-737: --- [~olegk] sorry about unfortunate choice

[jira] [Created] (HTTPCLIENT-2268) How do you cancel async request?

2023-03-30 Thread Patrick Barry (Jira)
Patrick Barry created HTTPCLIENT-2268: - Summary: How do you cancel async request? Key: HTTPCLIENT-2268 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2268 Project: HttpComponents HttpClient

[jira] [Commented] (HTTPCLIENT-2267) Connect called before Interceptors are invoked

2023-03-30 Thread Patrick Barry (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706929#comment-17706929 ] Patrick Barry commented on HTTPCLIENT-2267: --- Where can I got to see other

[jira] [Comment Edited] (HTTPCLIENT-2267) Connect called before Interceptors are invoked

2023-03-30 Thread Patrick Barry (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706929#comment-17706929 ] Patrick Barry edited comment on HTTPCLIENT-2267 at 3/30/23 3:17 PM: --

[GitHub] [httpcomponents-client] arturobernalg commented on pull request #429: Improve HttpByteArrayCacheEntrySerializer class by adding new methods and enhancing performance.

2023-03-30 Thread via GitHub
arturobernalg commented on PR #429: URL: https://github.com/apache/httpcomponents-client/pull/429#issuecomment-1490093869 > @arturobernalg Overall looks good. Could you please mark `ByteArrayCacheEntrySerializer` as deprecated and reference the new default implementation as its replacement

[GitHub] [httpcomponents-client] ok2c commented on pull request #429: Improve HttpByteArrayCacheEntrySerializer class by adding new methods and enhancing performance.

2023-03-30 Thread via GitHub
ok2c commented on PR #429: URL: https://github.com/apache/httpcomponents-client/pull/429#issuecomment-1489959364 @arturobernalg Overall looks good. Could you please mark `ByteArrayCacheEntrySerializer` as deprecated and reference the new default implementation as its replacement? -- Th

[jira] [Commented] (HTTPCORE-737) HttpClient not working with Java 8 runtime

2023-03-30 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706748#comment-17706748 ] Oleg Kalnichevski commented on HTTPCORE-737: [~akatkere] My Toolchain? It i

[jira] [Commented] (HTTPCORE-737) HttpClient not working with Java 8 runtime

2023-03-30 Thread Arun Katkere (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706746#comment-17706746 ] Arun Katkere commented on HTTPCORE-737: --- Pull request might not have worked with

[jira] [Commented] (HTTPCORE-737) HttpClient not working with Java 8 runtime

2023-03-30 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706745#comment-17706745 ] Oleg Kalnichevski commented on HTTPCORE-737: [~akatkere] What exactly makes

[jira] [Commented] (HTTPCORE-737) HttpClient not working with Java 8 runtime

2023-03-30 Thread Arun Katkere (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706742#comment-17706742 ] Arun Katkere commented on HTTPCORE-737: --- [~olegk] does WONTFIX mean httpcore5 wil

[jira] [Comment Edited] (HTTPCORE-737) HttpClient not working with Java 8 runtime

2023-03-30 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706737#comment-17706737 ] Oleg Kalnichevski edited comment on HTTPCORE-737 at 3/30/23 7:06 AM:

[jira] [Resolved] (HTTPCORE-737) HttpClient not working with Java 8 runtime

2023-03-30 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCORE-737. Resolution: Won't Fix Please see the associated PR for details. Oleg > HttpClie

[GitHub] [httpcomponents-core] ok2c closed pull request #399: HTTPCORE-737: Add maven.compiler.release if build jdk >= 9

2023-03-30 Thread via GitHub
ok2c closed pull request #399: HTTPCORE-737: Add maven.compiler.release if build jdk >= 9 URL: https://github.com/apache/httpcomponents-core/pull/399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [httpcomponents-core] ok2c commented on pull request #399: HTTPCORE-737: Add maven.compiler.release if build jdk >= 9

2023-03-30 Thread via GitHub
ok2c commented on PR #399: URL: https://github.com/apache/httpcomponents-core/pull/399#issuecomment-1489798750 > OK, in that case if we want httpcore5 to work on Java 8 runtime we just need to make sure we build with Java 8. In which case no pom.xml changes are required. @akatkere U