rschmitt merged PR #652:
URL: https://github.com/apache/httpcomponents-client/pull/652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@h
rschmitt merged PR #653:
URL: https://github.com/apache/httpcomponents-client/pull/653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@h
ok2c commented on PR #653:
URL:
https://github.com/apache/httpcomponents-client/pull/653#issuecomment-2988774603
@rschmitt I likewise prefer test cases to succeed fast, but I do not mind
some of them fail slow if that helps make them more reliable. Anyways, I have
nothing against magic nu
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated HTTPCLIENT-1846:
--
Fix Version/s: 5.6-alpha1
> Get content decoders using the Java Service Loader mec
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal resolved HTTPCLIENT-1846.
---
Resolution: Fixed
> Get content decoders using the Java Service Loader mechanism
arturobernalg merged PR #651:
URL: https://github.com/apache/httpcomponents-client/pull/651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
[
https://issues.apache.org/jira/browse/HTTPCLIENT-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17983726#comment-17983726
]
ASF subversion and git services commented on HTTPCLIENT-1843:
rschmitt commented on PR #653:
URL:
https://github.com/apache/httpcomponents-client/pull/653#issuecomment-2988627072
That's not _too_ different from what we're doing now, though, but I have a
few observations:
1. We can't set all the other timeouts to one minute. In order to test
lo
Hmm, yeah. If you look at the GitHub actions history, it shows when the
builds started failing.
Gary
On Thu, Jun 19, 2025, 11:37 Ryan Schmitt wrote:
> At this order of magnitude? I think it's unlikely. It could be a noisy
> neighbor issue, or a bug in the older version of macOS. The fact that
>
ok2c commented on PR #653:
URL:
https://github.com/apache/httpcomponents-client/pull/653#issuecomment-2988567509
@rschmitt This still feels a bit random. If all we want is to test whether a
certain timeout setting takes precedence over other settings, could not we set
all timeout to, say,
rschmitt opened a new pull request, #653:
URL: https://github.com/apache/httpcomponents-client/pull/653
These test cases are intermittently failing in the build environment on
macos-latest using JDK11, because some of the calls seem to be taking slightly
more than twice as long as they ough
At this order of magnitude? I think it's unlikely. It could be a noisy
neighbor issue, or a bug in the older version of macOS. The fact that
the actual timeout is almost exactly double what it's supposed to be
makes me think it's an issue with the TCP state machine, though,
similar to how TLS hands
Correction: the issue is in TestSocketTimeout, and we want to ensure
that all three ways of setting the socket timeout take effect. The
test expects a `SocketTimeoutException`, so we'll know if it stops
working.
On Thu, Jun 19, 2025 at 8:16 AM Ryan Schmitt wrote:
>
> There's something weird going
Could this be a clock granularity issue?
Gary
On Thu, Jun 19, 2025, 11:17 Ryan Schmitt wrote:
> There's something weird going on that's only affecting (macos-latest,
> 11). I can't reproduce it locally, even using the same JRE (Temurin
> 11.0.27+6) and architecture, although the environment mac
There's something weird going on that's only affecting (macos-latest,
11). I can't reproduce it locally, even using the same JRE (Temurin
11.0.27+6) and architecture, although the environment macOS is an
older version (14.7.6). The fact that the timeout is taking twice as
long as it ought to on JDK
ok2c commented on code in PR #651:
URL:
https://github.com/apache/httpcomponents-client/pull/651#discussion_r2156773826
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ContentCompressionExec.java:
##
@@ -81,36 +81,47 @@ public final class ContentCompression
arturobernalg commented on code in PR #651:
URL:
https://github.com/apache/httpcomponents-client/pull/651#discussion_r2156731216
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ContentCompressionExec.java:
##
@@ -81,36 +81,47 @@ public final class ContentCo
arturobernalg commented on code in PR #651:
URL:
https://github.com/apache/httpcomponents-client/pull/651#discussion_r2156502507
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ContentCompressionExec.java:
##
@@ -81,36 +80,34 @@ public final class ContentCo
ok2c commented on code in PR #651:
URL:
https://github.com/apache/httpcomponents-client/pull/651#discussion_r2156522185
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ContentCompressionExec.java:
##
@@ -81,36 +81,47 @@ public final class ContentCompression
ok2c commented on code in PR #651:
URL:
https://github.com/apache/httpcomponents-client/pull/651#discussion_r2156614712
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ContentCompressionExec.java:
##
@@ -81,36 +81,47 @@ public final class ContentCompression
ok2c commented on code in PR #651:
URL:
https://github.com/apache/httpcomponents-client/pull/651#discussion_r2156584909
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ContentCompressionExec.java:
##
@@ -81,36 +81,47 @@ public final class ContentCompression
ok2c commented on code in PR #651:
URL:
https://github.com/apache/httpcomponents-client/pull/651#discussion_r2156584909
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ContentCompressionExec.java:
##
@@ -81,36 +81,47 @@ public final class ContentCompression
arturobernalg commented on code in PR #651:
URL:
https://github.com/apache/httpcomponents-client/pull/651#discussion_r2156569239
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ContentCompressionExec.java:
##
@@ -81,36 +81,47 @@ public final class ContentCo
ok2c commented on PR #652:
URL:
https://github.com/apache/httpcomponents-client/pull/652#issuecomment-2987142052
@rschmitt Looks good but we need to fix the failing socket timeout tests
first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ok2c commented on code in PR #651:
URL:
https://github.com/apache/httpcomponents-client/pull/651#discussion_r2156402395
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ContentCompressionExec.java:
##
@@ -81,36 +80,34 @@ public final class ContentCompression
arturobernalg commented on code in PR #651:
URL:
https://github.com/apache/httpcomponents-client/pull/651#discussion_r2156361576
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/compress/CommonsCompressDecoderFactory.java:
##
@@ -0,0 +1,122 @@
+/*
+ *
26 matches
Mail list logo
