[PR] Check for keep-alive option support [httpcomponents-client]

2025-08-07 Thread via GitHub
rschmitt opened a new pull request, #702: URL: https://github.com/apache/httpcomponents-client/pull/702 See https://github.com/apache/httpcomponents-core/pull/544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Check for keep-alive option support [httpcomponents-core]

2025-08-07 Thread via GitHub
rschmitt opened a new pull request, #544: URL: https://github.com/apache/httpcomponents-core/pull/544 It turns out that keep-alive options are supported on all modern combinations of Java runtimes and operating systems, with the sole excpetion of Java 8 on Windows. The keep-alive options ar

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-07 Thread via GitHub
lethinker commented on PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#issuecomment-3166391150 > @lethinker https://github.com/apache/httpcomponents-client/blob/master/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/extension/async/StandardTestClientBu

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-07 Thread via GitHub
rschmitt commented on PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#issuecomment-3166384261 @lethinker https://github.com/apache/httpcomponents-client/blob/master/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/extension/async/StandardTestClientBuild

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-07 Thread via GitHub
lethinker commented on PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#issuecomment-3166241851 > > It seems that the effected ResponseTimeout is being rounded up to the nearest second, and milliseconds are not taking effect. > > @lethinker Socket timeout granul

Re: [PR] Mark HTTP/1.1 async connection as not open (non-reusable) as soon as it becomes closed by the opposite endpoint [httpcomponents-core]

2025-08-07 Thread via GitHub
ok2c commented on code in PR #543: URL: https://github.com/apache/httpcomponents-core/pull/543#discussion_r2261478046 ## httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java: ## @@ -277,13 +278,14 @@ public final void onInput(final ByteBuff

Re: [PR] Mark HTTP/1.1 async connection as not open (non-reusable) as soon as it becomes closed by the opposite endpoint [httpcomponents-core]

2025-08-07 Thread via GitHub
rschmitt commented on code in PR #543: URL: https://github.com/apache/httpcomponents-core/pull/543#discussion_r2261231341 ## httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java: ## @@ -277,13 +278,14 @@ public final void onInput(final Byte

Re: Stale connection reuse in the async client

2025-08-07 Thread Ryan Schmitt
I learned something very important, which explains why I'm seeing a lot of reports of TCP resets specifically: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/network-load-balancers.html#connection-idle-timeout For each TCP request that a client makes through a Network Load Balanc

Re: [PR] Discontinue use of SocketSupport to set extended socket options [httpcomponents-core]

2025-08-07 Thread via GitHub
rschmitt merged PR #542: URL: https://github.com/apache/httpcomponents-core/pull/542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.

Re: [PR] Discontinue use of SocketSupport to set extended socket options [httpcomponents-core]

2025-08-07 Thread via GitHub
rschmitt commented on code in PR #542: URL: https://github.com/apache/httpcomponents-core/pull/542#discussion_r2260863147 ## httpcore5/src/main/java/org/apache/hc/core5/io/SocketSupport.java: ## @@ -36,8 +36,11 @@ /** * @since 5.3 + * + * @deprecated No longer necessary, d

Re: [PR] Transparent async content (de)compression with gzip [httpcomponents-client]

2025-08-07 Thread via GitHub
arturobernalg merged PR #700: URL: https://github.com/apache/httpcomponents-client/pull/700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

Re: Stale connection reuse in the async client

2025-08-07 Thread Oleg Kalnichevski
What I'd like to know is: 1. Can we do anything to improve this race condition? Please try this change-set: https://github.com/apache/httpcomponents-core/pull/543 I should reduce the window of this race condition somewhat. Oleg

[PR] Mark HTTP/1.1 async connection as not open (non-reusable) as soon as it becomes closed by the opposite endpoint [httpcomponents-core]

2025-08-07 Thread via GitHub
ok2c opened a new pull request, #543: URL: https://github.com/apache/httpcomponents-core/pull/543 @rschmitt This should reduce the window of the stale connection lease race condition somewhat. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (HTTPCLIENT-2384) Socket options related to TcpKeepAlive are ignored

2025-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012608#comment-18012608 ] ASF subversion and git services commented on HTTPCLIENT-2384:

[jira] [Commented] (HTTPCLIENT-1822) Support for transparent content decompression

2025-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012607#comment-18012607 ] ASF subversion and git services commented on HTTPCLIENT-1822:

[jira] [Commented] (HTTPCLIENT-2385) Make Default...ClientConnection extensible

2025-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012606#comment-18012606 ] ASF subversion and git services commented on HTTPCLIENT-2385:

Re: [PR] Enable new TcpKeepAlive options on Java 8 [httpcomponents-client]

2025-08-07 Thread via GitHub
rschmitt merged PR #701: URL: https://github.com/apache/httpcomponents-client/pull/701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@h

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-07 Thread via GitHub
ok2c commented on PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#issuecomment-3164323292 > It seems that the effected ResponseTimeout is being rounded up to the nearest second, and milliseconds are not taking effect. @lethinker Socket timeout granularity of a

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-07 Thread via GitHub
lethinker commented on PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#issuecomment-3164276512 > @ok2c @rschmitt can you help me with the problem when I use the httpAsyncClient( httpclient 5.4.3 、jdk 21) First, I set a 100-second sleep on the server side to ensure th

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-07 Thread via GitHub
lethinker commented on PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#issuecomment-3164182716 @ok2c @rschmitt can you help me with the problem when I use the httpAsyncClient( httpclient 5.4.3 、jdk 21) First, I set a 100-second sleep on the server side to ensure t

[jira] [Commented] (HTTPCLIENT-2386) httpClient5 socketTimeoutException in dataChannel with connectTimeout value

2025-08-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012502#comment-18012502 ] ASF subversion and git services commented on HTTPCLIENT-2386:

Re: Stale connection reuse in the async client

2025-08-07 Thread Oleg Kalnichevski
On 2025-08-06 04:29, Ryan Schmitt wrote: Since rolling out 5.5 (which includes my change for `validateAfterInactivity`, which was previously interpreted as a connection TTL for async HTTP 1.1 connections), I've been getting reports of intermittent request failures which appear to be caused by

Re: [PR] HTTPCLIENT-2386: Classic transport to use connect timeout as a default if TLS timeout has not been explicitly set [httpcomponents-client]

2025-08-07 Thread via GitHub
ok2c commented on PR #699: URL: https://github.com/apache/httpcomponents-client/pull/699#issuecomment-3163033158 > Where is the original soTimeout restored after the handshake is completed? @rschmitt Good catch. Please do another pass. -- This is an automated message from the Apach

Re: [PR] Discontinue use of SocketSupport to set extended socket options [httpcomponents-core]

2025-08-07 Thread via GitHub
ok2c commented on code in PR #542: URL: https://github.com/apache/httpcomponents-core/pull/542#discussion_r2259386248 ## httpcore5/src/test/java/org/apache/hc/core5/io/TestSocketSupport.java: ## @@ -38,6 +38,7 @@ import org.junit.jupiter.api.Assertions; import org.junit.jupit

Re: [PR] Discontinue use of SocketSupport to set extended socket options [httpcomponents-core]

2025-08-07 Thread via GitHub
ok2c commented on code in PR #542: URL: https://github.com/apache/httpcomponents-core/pull/542#discussion_r2259384299 ## httpcore5/src/main/java/org/apache/hc/core5/io/SocketSupport.java: ## @@ -36,8 +36,11 @@ /** * @since 5.3 + * + * @deprecated No longer necessary, due t

Re: [PR] HTTPCLIENT-2386: Fix TLS handshake timeout precedence [httpcomponents-client]

2025-08-07 Thread via GitHub
ok2c commented on code in PR #694: URL: https://github.com/apache/httpcomponents-client/pull/694#discussion_r2259331530 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/DefaultAsyncClientConnectionOperator.java: ## @@ -165,7 +165,13 @@ public void completed(fina