Re: [PR] [HTTPCLIENT-2178] Implement Happy Eyeballs V2 (RFC 8305) [httpcomponents-client]

2025-08-11 Thread via GitHub
rschmitt commented on PR #693: URL: https://github.com/apache/httpcomponents-client/pull/693#issuecomment-3177760485 @ok2c What do you think of the idea of upgrading the existing `MultihomeConnectionInitiator`/`MultihomeIOSessionRequester` to support the RFC 8305 connection algorithm? --

Re: [PR] [HTTPCLIENT-2178] Implement Happy Eyeballs V2 (RFC 8305) [httpcomponents-client]

2025-08-11 Thread via GitHub
rschmitt commented on code in PR #693: URL: https://github.com/apache/httpcomponents-client/pull/693#discussion_r2268498321 ## httpclient5/src/test/java/org/apache/hc/client5/http/examples/AsyncClientHappyEyeballs.java: ## @@ -0,0 +1,158 @@ +/* + * =

[PR] IOSessionImpl: Support CloseMode.IMMEDIATE for Unix domain sockets [httpcomponents-core]

2025-08-11 Thread via GitHub
rschmitt opened a new pull request, #548: URL: https://github.com/apache/httpcomponents-core/pull/548 It's fine to set socket linger on a Unix-domain socket as long as it is done through the `SocketChannel` API. Calling `.socket()` always throws on a UDS-backed `SocketChannel`, however, whi

Re: [PR] Stale check command for async connections [httpcomponents-core]

2025-08-11 Thread via GitHub
rschmitt commented on PR #547: URL: https://github.com/apache/httpcomponents-core/pull/547#issuecomment-3176834982 > I think there's might be a race condition here involving command execution and connection closure. I think I was mistaken about this. The actual issue might have been

Re: [PR] Stale check command for async connections [httpcomponents-core]

2025-08-11 Thread via GitHub
rschmitt commented on PR #547: URL: https://github.com/apache/httpcomponents-core/pull/547#issuecomment-3176830951 I made the following changes locally: 1. I pulled in this change 2. I added https://github.com/apache/httpcomponents-core/pull/543 (specifically dfa2cd51c038f5f3259d10a5c

Re: [PR] Stale check command for async connections [httpcomponents-core]

2025-08-11 Thread via GitHub
rschmitt commented on code in PR #547: URL: https://github.com/apache/httpcomponents-core/pull/547#discussion_r2267919218 ## httpcore5/src/main/java/org/apache/hc/core5/http/nio/command/StaleCheckCommand.java: ## @@ -0,0 +1,58 @@ +/* + *

Re: [PR] Stale check command for async connections [httpcomponents-core]

2025-08-11 Thread via GitHub
rschmitt commented on PR #547: URL: https://github.com/apache/httpcomponents-core/pull/547#issuecomment-3176730639 Do you have the corresponding client changes? I tried integrating this into `PoolingAsyncClientConnectionManager` after the fashion of the H2 `PingCommand` code path, and now

Re: [PR] [HTTPCLIENT-2178] Implement Happy Eyeballs V2 (RFC 8305) [httpcomponents-client]

2025-08-11 Thread via GitHub
rschmitt commented on PR #693: URL: https://github.com/apache/httpcomponents-client/pull/693#issuecomment-3176355337 This is still on my to-do list, I'll get to it when I can. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Add Zstandardto async content compression [httpcomponents-client]

2025-08-11 Thread via GitHub
arturobernalg commented on code in PR #703: URL: https://github.com/apache/httpcomponents-client/pull/703#discussion_r2267620041 ## httpclient5/pom.xml: ## @@ -116,7 +116,7 @@ com.github.luben zstd-jni - test + 1.5.7-3 Review Comment: @ok2c a m

Re: [PR] Check for keep-alive option support [httpcomponents-client]

2025-08-11 Thread via GitHub
rschmitt merged PR #702: URL: https://github.com/apache/httpcomponents-client/pull/702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@h

Re: [PR] Mark HTTP/1.1 async connection as not open (non-reusable) as soon as it becomes closed by the opposite endpoint [httpcomponents-core]

2025-08-11 Thread via GitHub
rschmitt commented on code in PR #543: URL: https://github.com/apache/httpcomponents-core/pull/543#discussion_r2267489322 ## httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java: ## @@ -277,13 +278,14 @@ public final void onInput(final Byte

Re: [PR] Add Zstandardto async content compression [httpcomponents-client]

2025-08-11 Thread via GitHub
ok2c commented on code in PR #703: URL: https://github.com/apache/httpcomponents-client/pull/703#discussion_r2267030668 ## httpclient5/pom.xml: ## @@ -116,7 +116,7 @@ com.github.luben zstd-jni - test + 1.5.7-3 Review Comment: @arturobernalg Is

Re: [PR] Mark HTTP/1.1 async connection as not open (non-reusable) as soon as it becomes closed by the opposite endpoint [httpcomponents-core]

2025-08-11 Thread via GitHub
ok2c commented on code in PR #543: URL: https://github.com/apache/httpcomponents-core/pull/543#discussion_r2267013823 ## httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java: ## @@ -277,13 +278,14 @@ public final void onInput(final ByteBuff

Re: [PR] Content coding support [httpcomponents-client]

2025-08-11 Thread via GitHub
ok2c commented on PR #704: URL: https://github.com/apache/httpcomponents-client/pull/704#issuecomment-3175171765 > @ok2c per RFC 9110[ (§8.4)](https://datatracker.ietf.org/doc/html/rfc9110#name-content-encoding) Content-Encoding lists codings in apply-order, so we should decode right→left