Re: [PR] Add Zstandardto async content compression [httpcomponents-client]

2025-08-15 Thread via GitHub
arturobernalg commented on PR #703: URL: https://github.com/apache/httpcomponents-client/pull/703#issuecomment-3192281414 @ok2c please do another pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] HTTPCLIENT-2387: Micrometer/OTel observations & metrics (5.6) [httpcomponents-client]

2025-08-15 Thread via GitHub
arturobernalg opened a new pull request, #706: URL: https://github.com/apache/httpcomponents-client/pull/706 Add httpclient5-observation with timers/counters for classic/async, IO bytes, pool gauges, DNS/TLS meters; Observation interceptors; MetricConfig & options; offline tests; optional d

Re: [PR] Content coding support [httpcomponents-client]

2025-08-15 Thread via GitHub
rpkrajewski commented on PR #704: URL: https://github.com/apache/httpcomponents-client/pull/704#issuecomment-3191767649 ThanksĀ - I will experiment more with this when 5.6 is out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] Bump actions/checkout from 4 to 5 [httpcomponents-core]

2025-08-15 Thread via GitHub
dependabot[bot] opened a new pull request, #549: URL: https://github.com/apache/httpcomponents-core/pull/549 Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's relea

[PR] Bump actions/checkout from 4 to 5 [httpcomponents-client]

2025-08-15 Thread via GitHub
dependabot[bot] opened a new pull request, #705: URL: https://github.com/apache/httpcomponents-client/pull/705 Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's rel

Re: [PR] Add Zstandardto async content compression [httpcomponents-client]

2025-08-15 Thread via GitHub
ok2c commented on code in PR #703: URL: https://github.com/apache/httpcomponents-client/pull/703#discussion_r2278903822 ## httpclient5/src/main/java/org/apache/hc/client5/http/async/methods/DeflatingZstdEntityProducer.java: ## @@ -0,0 +1,345 @@ +/* + * =

Re: [PR] Stale check command for async connections [httpcomponents-core]

2025-08-15 Thread via GitHub
ok2c commented on PR #547: URL: https://github.com/apache/httpcomponents-core/pull/547#issuecomment-3191387740 @arturobernalg @rschmitt Please do one more pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Stale check command for async connections [httpcomponents-core]

2025-08-15 Thread via GitHub
ok2c commented on PR #547: URL: https://github.com/apache/httpcomponents-core/pull/547#issuecomment-3191387376 > > https://github.com/rschmitt/httpcomponents-core/tree/stale_conn_check_async > > `H2ConnPool#validateSession()` still enqueues `PingCommand`, consider swapping it for `S

Re: [PR] Stale check command for async connections [httpcomponents-core]

2025-08-15 Thread via GitHub
ok2c commented on PR #547: URL: https://github.com/apache/httpcomponents-core/pull/547#issuecomment-3191386198 > And a well-behaved _client_ should not attempt to reuse a connection on which it has already received a `GOAWAY` @rschmitt This should be the case already. Connections sho

Re: [PR] Stale check command for async connections [httpcomponents-core]

2025-08-15 Thread via GitHub
arturobernalg commented on PR #547: URL: https://github.com/apache/httpcomponents-core/pull/547#issuecomment-3191248416 > https://github.com/rschmitt/httpcomponents-core/tree/stale_conn_check_async `H2ConnPool#validateSession()` still enqueues `PingCommand`, consider swapping it for