Github user CanardSauvage commented on the pull request:
https://github.com/apache/httpclient/pull/35#issuecomment-149151101
What is the status, we would be really happy if this method mades it into
the next release.
---
If your project is set up for it, you can reply to this email
Github user CanardSauvage commented on the pull request:
https://github.com/apache/httpclient/pull/35#issuecomment-138592010
@michael-o Boolean parameters are an anti pattern, cf. Clean Code
I changed the name.
---
If your project is set up for it, you can reply to this
Github user CanardSauvage commented on the pull request:
https://github.com/apache/httpclient/pull/35#issuecomment-134560658
Maybe complete is the wrong word. The class is for proper URL building and
this is a convenience method that helps to reduce code. It would make the class
Github user CanardSauvage commented on the pull request:
https://github.com/apache/httpclient/pull/35#issuecomment-134552803
Well, the pull request is against the trunk, so it would be applied to 5.0,
or am I wrong?
I don't think this is a specific use case. In my opinio
Github user CanardSauvage commented on the pull request:
https://github.com/apache/httpclient/pull/35#issuecomment-134542001
Because you would need to do an if with StringUtils.isEmpty for every
parameter. We build a lot of urls for redirects and for links with a lot of
parameters
GitHub user CanardSauvage opened a pull request:
https://github.com/apache/httpclient/pull/35
URIBuilder extended for new method for empty values
We are using the URIBuilder heavily across many projects. Before this we
had our only implementation of an 'UrlBuilder' but
