[GitHub] httpclient issue #74: WIP: OpenTracing integration

2017-05-12 Thread adriancole
Github user adriancole commented on the issue: https://github.com/apache/httpclient/pull/74 Oleg, thinking in general here.. I think one hook approach that would be nice to see in any instrumentation library is an interface like this.. Scope newScope(Attributes

[GitHub] httpclient issue #74: WIP: OpenTracing integration

2017-05-12 Thread adriancole
Github user adriancole commented on the issue: https://github.com/apache/httpclient/pull/74 > > @adriancole <https://github.com/adriancole> Adrain, feel to propose or, > better, to contribute "clean hooks into executors or other means to start >

[GitHub] httpclient issue #74: WIP: OpenTracing integration

2017-05-12 Thread adriancole
Github user adriancole commented on the issue: https://github.com/apache/httpclient/pull/74 hey, oleg. different project but same problem. Here's an example of instrumenting the async client w/ v4.3 (apologies I made no useful code comments explaining..)

[GitHub] httpclient pull request #74: WIP: OpenTracing integration

2017-04-28 Thread adriancole
Github user adriancole commented on a diff in the pull request: https://github.com/apache/httpclient/pull/74#discussion_r114044778 --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/sync/HttpClientBuilder.java --- @@ -888,6 +898,10 @@ public void close() throws

[GitHub] httpclient issue #74: WIP: OpenTracing integration

2017-04-28 Thread adriancole
Github user adriancole commented on the issue: https://github.com/apache/httpclient/pull/74 as much as I like tracing, I also think it would be extremely unwise to add more deps to the bottom of the stack (which is often where httpclient is), particularly in v0 apis that have few