Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/99
That's all fine with me of course, but I'd want to make sure the Javadocs
are updated so it is easy to understand what a timeout applies to but I did not
check the state
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/99
Hi @rschmitt ,
Are you worried about making ```RequestConfig``` more 'crowded' and
confusing and are therefore piggybacking on top of another setting? Or, would
the b
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/94
Hi @dmap
Thank you for your contribution!
How about adding some unit tests?
Gary
---
-
To
Github user garydgregory closed the pull request at:
https://github.com/apache/httpcomponents-core/pull/90
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/90
PR merged; local build OK; closing.
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/90
@ok2c , OK, thank you.
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/90
@ok2c With my latest commits, all Travis CI builds are green for this PR.
---
-
To unsubscribe, e-mail: dev
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/90#discussion_r225022740
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/concurrent/BasicFuture.java ---
@@ -94,7 +95,7 @@ public synchronized T get(final
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/90#discussion_r225006254
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/concurrent/BasicFuture.java ---
@@ -94,7 +95,7 @@ public synchronized T get(final
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/90
@ok2c I will reply/work on it when I get home tonight (on my phone ATM.)
---
-
To unsubscribe, e-mail: dev
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/90#discussion_r224965993
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/concurrent/BasicFuture.java ---
@@ -94,7 +95,7 @@ public synchronized T get(final
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/90#discussion_r224963982
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/concurrent/BasicFuture.java ---
@@ -94,7 +95,7 @@ public synchronized T get(final
GitHub user garydgregory opened a pull request:
https://github.com/apache/httpcomponents-core/pull/90
Define a timeout exception more precisely.
Create and use a subclass of java.util.concurrent.TimeoutException called
TimeoutValueException to precisely define a timeout exception
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
It would be great to show a small program that demonstrates the performance
difference. Maybe something that can be run before and after the patch is
applied
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/64
I committed this PR with some minor changes to the branch 4.4.x. Please
verify and close.
---
-
To unsubscribe
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/64
Sounds reasonable to me. @ok2c ?
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional
Github user garydgregory commented on the issue:
https://github.com/apache/httpasyncclient/pull/6
@383124397 Please provide your patch on top of the HEAD of the 4.1.x
branch. It looks like you are based on code from a 4.1.1-SNAPSHOT. Thank you
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-client/pull/100
@ok2c : Oops, I did not realize we were talking about 5.0, sorry. So yeah,
changing the current interface makes sense
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-client/pull/100
Wouldn't adding a method to an existing interface break BC? Are we OK with
that or would we/should we introduce a subinte
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/49
Could there be fewer changes if a CopyOnWriteArrayList is used instead of
an ArrayList in HeaderGroup?
---
If your project is set up for it, you can reply to this email and have
Github user garydgregory commented on the issue:
https://github.com/apache/httpclient/pull/76
I do not see any either . You can be the first ;-)
HttpCore 5 GA has to come first. Oleg can speak to schedule. I think it
will be a while though. We are in alpha mode
Github user garydgregory commented on the issue:
https://github.com/apache/httpclient/pull/75
Tracking through a new ticket here:
https://issues.apache.org/jira/browse/HTTPCLIENT-1843
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user garydgregory commented on the issue:
https://github.com/apache/httpclient/pull/75
Oops, wrong project, can you please patch against Apache Commons Compress?
https://github.com/apache/commons-compress
Thank you,
Gary
---
If your project is set up for it, you
Github user garydgregory commented on the issue:
https://github.com/apache/httpclient/pull/75
We're all good :-) I only intended to mention the project is alive and well
:-) And I meant to say Apache Commons Compress
(https://commons.apache.org/proper/commons-compress/), not
Github user garydgregory commented on the issue:
https://github.com/apache/httpclient/pull/75
Commons Codec is alive and well and released fairly regularly. Disclosure:
I am the project chair over at Apache Commons. Feel free to create a Jira or PR
in Common Compress ;-)
---
If
Github user garydgregory commented on the issue:
https://github.com/apache/httpcore/pull/42
I applied the patch to 4.4.x. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user garydgregory commented on the issue:
https://github.com/apache/httpcore/pull/41
@lujianbo so it sounds like "go for it". I'd suggest you port the trunk
code to the 4.4 branch in a new PR.
---
If your project is set up for it, you can reply to this emai
Github user garydgregory commented on the issue:
https://github.com/apache/httpcore/pull/41
Based on our current versioning policy and recent discussions about other
features, this would not be appropriate in a bug fix version like 4.4.7 but
should go in as a new API/feature in a 4.5
Github user garydgregory commented on the issue:
https://github.com/apache/httpcore/pull/41
I can see that. My point is that it is confusing to allow a user to set
both and have one used and not the other when this is not even documented in a
Javadoc comment. Do you really need both
Github user garydgregory commented on the issue:
https://github.com/apache/httpclient/pull/64
Yes!
On Tue, Feb 7, 2017 at 4:35 PM, Coderec wrote:
> *@Coderec* commented on this pull request.
> --
>
> In httpclient/s
Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/httpclient/pull/64#discussion_r99966404
--- Diff:
httpclient/src/main/java/org/apache/http/client/utils/URIBuilder.java ---
@@ -492,8 +492,8 @@ public String toString
Github user garydgregory commented on the issue:
https://github.com/apache/httpclient/pull/56
Hi Simone!
Nice to see a patch from you.
Is there a way all this new code can be unit tested?
I know that running an OSGi container in a "unit" test is he
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/26#issuecomment-195153712
Thank you for the updated patch!
Committed revision 1734489.
Gary
---
If your project is set up for it, you can reply to this email and have
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/26#issuecomment-194998971
I think that if you want to have this kind of change, I would like it
better if there was a code comment on the ctor that read something like "Do not
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/25#issuecomment-194997788
Thank you for your patch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/25#issuecomment-194996238
Hi,
In the future, please run a build before you submit a patch. This patch
fails our checkstyle rules:
>
E:\vcs\svn\apache\httpcomponents\tr
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/24#issuecomment-194995325
Hi,
Thank you for your patch!
Committed revision 1734442.
Gary
---
If your project is set up for it, you can reply to this email and
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/23#issuecomment-194992409
Hi,
Thank you for your patch!
Committed revision 1734440.
Gary
---
If your project is set up for it, you can reply to this email and
Github user garydgregory commented on the pull request:
https://github.com/apache/httpclient/pull/45#issuecomment-180664477
Committed to trunk and 4.5.x branch. Please verify and close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user garydgregory commented on the pull request:
https://github.com/apache/httpclient/pull/45#issuecomment-180664451
```
commit -m "[HTTPCLIENT-1717] Make fluent API .Content.Content(byte[],
ContentType) public." -N
E:/vcs/svn/apache/httpcomponents/trunk/
Github user garydgregory commented on the pull request:
https://github.com/apache/httpclient/pull/45#issuecomment-180664397
commit -m "[HTTPCLIENT-1717] Make fluent API .Content.Content(byte[],
ContentType) public." -N
E:/vcs/svn/apache/httpcomponents/branches/4.5.x/
Github user garydgregory commented on the pull request:
https://github.com/apache/httpclient/pull/45#issuecomment-180197902
I'm OK with that. Oleg? Should we make the ctor public or add a factory
method?
---
If your project is set up for it, you can reply to this email and have
Github user garydgregory commented on the pull request:
https://github.com/apache/httpcore/pull/20#issuecomment-177623136
Patch applied:
Committed revision 1727859.
Please verify and close.
Thank you @HendricksonJS !
---
If your project is set up for it
Github user garydgregory commented on the pull request:
https://github.com/apache/httpclient/pull/42#issuecomment-174836007
I committed this patch to
https://svn.apache.org/repos/asf/httpcomponents/httpclient/branches/4.5.x:
> commit -m "[HTTPCLIENT-1
Github user garydgregory commented on the pull request:
https://github.com/apache/httpclient/pull/40#issuecomment-167711849
Committed to git master. Please verify and close. In Apache's Jira as
[HTTPCLIENT-1709].
---
If your project is set up for it, you can reply to this emai
45 matches
Mail list logo
