[GitHub] httpcore issue #30: HTTPCORE-431 Fix EntityUtils encoding for application/js...

2016-09-04 Thread hirthwork
Github user hirthwork commented on the issue: https://github.com/apache/httpcore/pull/30 > To be clear, the performance penalty you're thinking of is a string comparison of the MIME type? I'm talking about single bytes reading and input streams concatenat

[GitHub] httpcore issue #30: HTTPCORE-431 Fix EntityUtils encoding for application/js...

2016-09-02 Thread hirthwork
Github user hirthwork commented on the issue: https://github.com/apache/httpcore/pull/30 1. This code makes no distinction between BE and LE encodings described in [rfc4627](https://tools.ietf.org/html/rfc4627#section-3). 2. [rfc7159](https://tools.ietf.org/html/rfc7159#section

[GitHub] httpasyncclient issue #5: fix HttpAsyncMethods.createPost/createPut(URI,byte...

2016-08-28 Thread hirthwork
Github user hirthwork commented on the issue: https://github.com/apache/httpasyncclient/pull/5 Works fine. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] httpasyncclient pull request #5: fix HttpAsyncMethods.createPost/createPut(U...

2016-08-28 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpasyncclient/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] httpasyncclient pull request #5: fix HttpAsyncMethods.createPost/createPut(U...

2016-08-23 Thread hirthwork
GitHub user hirthwork opened a pull request: https://github.com/apache/httpasyncclient/pull/5 fix HttpAsyncMethods.createPost/createPut(URI,byte[],ContentType) Set entity to request. Without this request payload will be empty You can merge this pull request into a Git repository

[GitHub] httpcore pull request: Support 64-bit chunk headers

2016-04-06 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpcore/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] httpcore pull request: Fix race condition in org.apache.http.nio.p...

2016-04-05 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpcore/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] httpcore pull request: Support 64-bit chunk headers

2016-04-04 Thread hirthwork
GitHub user hirthwork opened a pull request: https://github.com/apache/httpcore/pull/28 Support 64-bit chunk headers Some caching servers (like nginx) doesn't send Content-Length for cached responses from upstream which returned chunked response. The only way to ensure response

[GitHub] httpcore pull request: Fix race condition in org.apache.http.nio.p...

2016-02-16 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpcore/pull/21#issuecomment-184778992 After 1 hour of load testing no connection leaks detected. I suggest to consider ok2c@38a2f78 as fix for this race condition --- If your project is set up

[GitHub] httpcore pull request: Fix race condition in org.apache.http.nio.p...

2016-02-15 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpcore/pull/21#issuecomment-184234519 Yeah, I've seen 4c5947e4913c983b905d9d79db123a5b900a8b9a during race condition investigation, it was a very useful for me. Your patch seems pretty valid for me

[GitHub] httpcore pull request: Fix race condition in org.apache.http.nio.p...

2016-02-05 Thread hirthwork
GitHub user hirthwork opened a pull request: https://github.com/apache/httpcore/pull/21 Fix race condition in org.apache.http.nio.protocol.HttpAsyncRequestExecutor.endOfInput and org.apache.http.impl.nio.client.AbstractClientExchangeHandler.connectionAllocated(conn) Got pretty bad

[GitHub] httpclient pull request: Cache request line in HttpRequestWrapper

2015-06-04 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpclient/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] httpclient pull request: Cache request line in HttpRequestWrapper

2015-06-04 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpclient/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] httpcore pull request: Enable https protocol for TestHttpsAsyncTim...

2015-06-03 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpcore/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] httpclient pull request: Cache request line in HttpRequestWrapper

2015-06-03 Thread hirthwork
GitHub user hirthwork opened a pull request: https://github.com/apache/httpclient/pull/32 Cache request line in HttpRequestWrapper Copy of https://github.com/apache/httpclient/pull/31 for 4.5.x For each request HttpAsyncClient calls HttpRequestWrapper.getRequestLine() 8

[GitHub] httpclient pull request: Cache request line in HttpRequestWrapper

2015-06-03 Thread hirthwork
GitHub user hirthwork opened a pull request: https://github.com/apache/httpclient/pull/31 Cache request line in HttpRequestWrapper For each request HttpAsyncClient calls HttpRequestWrapper.getRequestLine() 8 times during single request execution. For URIs containing non-ASCII

[GitHub] httpasyncclient pull request: Customizable CharsetDecoder in Async...

2015-02-08 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpasyncclient/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] httpasyncclient pull request: Customizable CharsetDecoder in Async...

2015-02-08 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpasyncclient/pull/2#issuecomment-73466127 Thanks a lot --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] httpasyncclient pull request: Customizable CharsetDecoder in Async...

2015-02-02 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpasyncclient/pull/2#issuecomment-72424340 bump --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] httpasyncclient pull request: Customizable CharsetDecoder in Async...

2015-01-28 Thread hirthwork
GitHub user hirthwork opened a pull request: https://github.com/apache/httpasyncclient/pull/2 Customizable CharsetDecoder in AsyncCharConsumer Some servers doesn't specify Content-Type header, while sending response in UTF-8. This change will allow to consume such servers responses

[GitHub] httpcore pull request: Set EmptyInputStream in entity instead of C...

2014-11-14 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpcore/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] httpcore pull request: Set EmptyInputStream in entity instead of C...

2014-11-14 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpcore/pull/8#issuecomment-63104037 Thanks a lot --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] httpcore pull request: Reduce synchronized scopes in IOSessionImpl

2014-11-13 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpcore/pull/7#issuecomment-62960585 f0f1a6693690774c1cb0 still have some issues (not related to the IOSessionImpl) with asynchronous connections closing, so let it be just a gist, but not the part

[GitHub] httpcore pull request: Reduce synchronized scopes in IOSessionImpl

2014-11-12 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpcore/pull/7#issuecomment-62699517 Yes, this is a part of performance improvement, but I don't believe you want to have these [crutches](https://gist.github.com/hirthwork/f0f1a6693690774c1cb0) in master

[GitHub] httpcore pull request: Reduce synchronized scopes in IOSessionImpl

2014-11-12 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpcore/pull/7#issuecomment-62743426 One weird thing concerning async channel close: there is no time guarantees concerning FIN packet sending. Close requests are being stored to the executor queue, so

[GitHub] httpcore pull request: Set EmptyInputStream in entity instead of C...

2014-11-12 Thread hirthwork
GitHub user hirthwork opened a pull request: https://github.com/apache/httpcore/pull/8 Set EmptyInputStream in entity instead of ContentLengthInputStream(in, 0) # Problem description 1. If HttpClient receives response with `Content-Length: 0` the connection won't be returned

[GitHub] httpcore pull request: Reduce synchronized scopes in IOSessionImpl

2014-11-12 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpcore/pull/7#issuecomment-62780779 Thanks a lot --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] httpcore pull request: Reduce synchronized scopes in IOSessionImpl

2014-11-12 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpcore/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] httpcore pull request: Reduce synchronized scopes in IOSessionImpl

2014-11-11 Thread hirthwork
GitHub user hirthwork opened a pull request: https://github.com/apache/httpcore/pull/7 Reduce synchronized scopes in IOSessionImpl Currently IOSessionImpl has too many synchronized methods which results in poor performance on high load. Changes consist of two commits: First

[GitHub] httpcore pull request: Reduce synchronized scopes in IOSessionImpl

2014-11-11 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpcore/pull/7#issuecomment-62673889 Pull request simplified. The only blocking operation is .close() (because of dup2 called by preClose0), so no double checks required. Just synchronized scope of .close

[GitHub] httpcore pull request: Allow custom processing for Response alrea...

2014-10-15 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpcore/pull/5#issuecomment-59192055 Javadocs added. I understand your concerns but double response submission is not so rare case when implementing HTTP proxy which sends bunch of subrequests

[GitHub] httpcore pull request: Allow custom processing for Response alrea...

2014-10-15 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpcore/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] httpcore pull request: Allow custom processing for Response alrea...

2014-10-14 Thread hirthwork
GitHub user hirthwork opened a pull request: https://github.com/apache/httpcore/pull/5 Allow custom processing for Response already submitted errors Currently, second call of exchage.submitResponse() will raise IllegalStateException. There is no way to log any additional

[GitHub] httpcore pull request: Fix HttpContext loss on exception in reques...

2014-10-08 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpcore/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] httpasyncclient pull request: ZeroCopyConsumer: preserve content e...

2014-09-23 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpasyncclient/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] httpasyncclient pull request: ZeroCopyConsumer: preserve content e...

2014-09-23 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpasyncclient/pull/1#issuecomment-56494258 Thank you for prompt response --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] httpasyncclient pull request: ZeroCopyConsumer: preserve content e...

2014-09-22 Thread hirthwork
GitHub user hirthwork opened a pull request: https://github.com/apache/httpasyncclient/pull/1 ZeroCopyConsumer: preserve content encoding Currently ZeroCopyConsumer builds HttpEntity which doesn't contain content encoding from the original entity. This patch stores original content

[GitHub] httpclient pull request: Ignore unsupported cookie policies

2014-09-08 Thread hirthwork
Github user hirthwork closed the pull request at: https://github.com/apache/httpclient/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] httpclient pull request: Ignore unsupported cookie policies

2014-09-08 Thread hirthwork
Github user hirthwork commented on the pull request: https://github.com/apache/httpclient/pull/18#issuecomment-54793571 According to my tests HttpAsyncClient is compatible with the trunk version of HttpClient now --- If your project is set up for it, you can reply to this email

[GitHub] httpclient pull request: Ignore unsupported cookie policies

2014-09-07 Thread hirthwork
GitHub user hirthwork opened a pull request: https://github.com/apache/httpclient/pull/18 Ignore unsupported cookie policies Do not throw HttpException on uknown policies. This will provide additional backward compatibility for HttpAsyncClient. For more infomation see