Github user ok2c commented on the pull request:
https://github.com/apache/httpclient/pull/12#issuecomment-44973982
Overall, good stuff. I'll merge the changes once all little things have
been dealt with.
Oleg
---
If your project is set up for it, you can reply to this
Github user ok2c commented on the pull request:
https://github.com/apache/httpclient/pull/12#issuecomment-45020893
Committed to SVN trunk with some minor changes.
http://svn.apache.org/r1599798
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcore/pull/1#discussion_r15877520
--- Diff: httpcore/src/main/java/org/apache/http/HttpHost.java ---
@@ -262,9 +278,12 @@ public boolean equals(final Object obj) {
}
if
Github user ok2c commented on the pull request:
https://github.com/apache/httpcore/pull/1#issuecomment-51685989
Committed to SVN trunk.
http://svn.apache.org/r1616939
Oleg
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ok2c commented on the pull request:
https://github.com/apache/httpcore/pull/1#issuecomment-51776141
Could you please close this PR and open a new one given this change is
completely unrelated to the original issue?
---
If your project is set up for it, you can reply to
Github user ok2c commented on the pull request:
https://github.com/apache/httpclient/pull/16#issuecomment-52022616
Committed to SVN trunk
http://svn.apache.org/r1617683
Oleg
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ok2c commented on the pull request:
https://github.com/apache/httpcore/pull/2#issuecomment-52023118
Committed to SVN trunk
http://svn.apache.org/r1617685
Oleg
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-client/pull/88#discussion_r151871562
--- Diff:
httpclient5/src/main/java/org/apache/hc/client5/http/auth/AuthCache.java ---
@@ -45,4 +45,8 @@
void clear
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-client/pull/88#discussion_r151940280
--- Diff:
httpclient5/src/main/java/org/apache/hc/client5/http/auth/AuthCache.java ---
@@ -45,4 +45,8 @@
void clear
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-client/pull/88#discussion_r152042431
--- Diff:
httpclient5/src/main/java/org/apache/hc/client5/http/auth/AuthCache.java ---
@@ -45,4 +45,8 @@
void clear
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@xiaoshuang-lu We cannot just add an extra dependency to the stable (GA)
release branch.
---
-
To unsubscribe, e
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@xiaoshuang-lu master. I have a question, though. Why should HttpClient
depend on dropwizard in the first place
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@xiaoshuang-lu Have you looked at the new 5.0 APIs, more specifically at
the exec interceptors? If you find exec interceptors insufficient to collect
all the requires metrics feel free to
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@xiaoshuang-lu I do not see gRPC require dropwizard
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@xiaoshuang-lu and what if I _want_ to use dropwizard?
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@xiaoshuang-lu No, I mean forcing all users to use one particular framework
without any good reason.
---
-
To
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/56
@agherardi Could you please help me better understand what you are trying
to achieve? Why would you want to avoid calling `#close` method when it is a
part of `InputStream` contract? I also
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/56
@agherardi OK. I see. While it is not pretty I understand the rationale for
the work-around. There are cases when clients might want to consume the payload
which has some sort of format
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-client/pull/91#discussion_r161406549
--- Diff:
httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheEntryUpdater.java
---
@@ -103,6 +103,8 @@ public HttpCacheEntry
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/91
@catchsudheera Committed to 4.5.x, 4.6.x and master. Please review and
close this PR.
---
-
To unsubscribe, e-mail
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/94
@catchsudheera Committed to master. Please review and close this PR.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/57
I fully agree with @reschke. Being 'clever' about such severe protocol
violations is not good idea. However I would happily commit a patch failing 204
responses with `Content-
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/57
@agherardi An alternative would be to throw a `ProtocolException` from a
response interceptor, however the solution you have proposed looks better to me
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/95
@agherardi Looks good to me. However this fix should go into HttpCore
[DefaultConnectionReuseStrategy](https://github.com/apache/httpcomponents-core/blob/master/httpcore5/src/main/java/org
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/57
@agherardi Committed to master and 4.4.x with some minor tweaks. Please
review
---
-
To unsubscribe, e-mail: dev
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/58
@imoldovan-intacct Your code makes use of Java 1.8 specific features which
makes the change-set incompatible with the current versions of HttpCore.
HttpCore 4.4 still requires Java 1.6 and
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/59#discussion_r168495541
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/ExpandableBuffer.java
---
@@ -123,6 +123,10 @@ protected void expand
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/59#discussion_r168497884
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/ExpandableBuffer.java
---
@@ -123,6 +123,10 @@ protected void expand
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/59#discussion_r168499443
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/ExpandableBuffer.java
---
@@ -123,6 +123,10 @@ protected void expand
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/59
@imoldovan-intacct I would rather use `BufferOverflowException` instead of
`MessageConstraintException`
---
-
To
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/100
@kirill-usov Kirill, could you please briefly describe what you are trying
to accomplish with these changes? I think HttpClient 5.0 already supports 1xx
message processing through
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/100
@kirill-usov It most definitely works with minimal HttpAsyncClient
```
final IOReactorConfig ioReactorConfig = IOReactorConfig.custom()
.setSoTimeout(Timeout.ofSeconds
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/100
What I do not like about your patch is that it introduces another callback
interface (`HttpClientAsyncExecutionCallback`). I believe it would be cleaner
to add `#informationResponse` to
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/100
@garydgregory I see no problem with making small profile API changes to 5.0
while we are still in BETA
---
-
To
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/100
@kirill-usov HC 5.0 is still BETA. Some API changes are still to be
expected. We are still many months away from the API freeze. I suggest that we
do the right thing and fix what needs
Github user ok2c commented on the issue:
https://github.com/apache/httpasyncclient/pull/6
@383124397 Exactly what kind of changes are you proposing? Your pull
request looks completely messed up. Please resolve all conflicts and resubmit
Github user ok2c commented on the issue:
https://github.com/apache/httpasyncclient/pull/6
@383124397 could you please either update the change-set or close this pull
request?
---
-
To unsubscribe, e-mail: dev
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/60
@kirill-usov Pushed to master. Please review and close
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For
Github user ok2c commented on the issue:
https://github.com/apache/httpasyncclient/pull/7
@383124397 Why do you want to restart a shut down `HttpAsyncClient`
instance instead of creating a new one?
---
-
To
Github user ok2c commented on the issue:
https://github.com/apache/httpasyncclient/pull/7
@383124397 I have never _ever_ seen a complex system capable of recovering
from OOM condition and I have seen a few. I personally would not attempt to
recover a shut down client and would simply
Github user ok2c commented on the issue:
https://github.com/apache/httpasyncclient/pull/7
@383124397 You own application causes OOM condition and you are worrying
about resiliently and high availability of HttpAsyncClient
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/61
@sparsick Committed to master. Many thanks for contributing the patch.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user ok2c commented on the issue:
https://github.com/apache/httpasyncclient/pull/7
@383124397 OOM in Java is considered a _fatal_ error. If HttpAsycClient was
unable to allocate some of its internal structures it may no longer be in a
consistent state. This is the reason why
Github user ok2c commented on the issue:
https://github.com/apache/httpasyncclient/pull/7
@383124397 Would you mind closing this PR?
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional
Github user ok2c commented on the issue:
https://github.com/apache/httpasyncclient/pull/8
@nobodyiam Looks reasonable and well researched to me. Would you mind,
though, adding a test case to the existing integration test suite?
https://github.com/apache/httpasyncclient/blob/4.1.x
Github user ok2c commented on the issue:
https://github.com/apache/httpasyncclient/pull/8
@nobodyiam Change-set committed as
401cebe5d1492102c2cd3edaa777fc67b1b424a5. Please review and close the PR.
---
-
To
Github user ok2c commented on the issue:
https://github.com/apache/httpasyncclient/pull/8
@nobodyiam No immediate plans. It is likely to take a few more months.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/63
@reschke Committed to 4.4.x branch. Please review and close.
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/101
Related to HTTPCLIENT-1920
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/102
@chenying99 _please_ **close** this pull request! It drags in 181 unrelated
commits. Please close this pull request or reduce the change-set just to those
changes you are proposing
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-client/pull/103#discussion_r187589736
--- Diff:
httpclient/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java
---
@@ -375,7 +375,7 @@ public synchronized
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-client/pull/103#discussion_r187595171
--- Diff:
httpclient/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java
---
@@ -375,7 +375,7 @@ public synchronized
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-client/pull/103#discussion_r187599055
--- Diff:
httpclient/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java
---
@@ -375,7 +375,7 @@ public synchronized
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/103
@overquota Committed to 4.5.x and 4.6.x with some minor tweaks. Please
review and close the PR.
---
-
To unsubscribe
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/103
Q2/Q3 2018
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/64
@jasontedor @garydgregory Works for me.
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/65
@varunnvs92 Is there a reason for adding `Automatic-Module-Name` to
HttpCore main module and not to any other modules
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/65
@varunnvs92 Can we make module names consistent with those used by Maven
metadata?
httpcore: `org.apache.httpcomponents.httpcore`
httpcore-nio
Github user ok2c commented on the issue:
https://github.com/apache/httpasyncclient/pull/9
@fbe Committed to SVN
http://svn.apache.org/viewvc?rev=1833315&view=rev
Please review and close thi
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/104
@varunnvs92 Committed to 4.5.x and 4.6.x
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/65
@varunnvs92 Hopefully by the end of the month.
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/66
@xiaohu-zhang Please fix the change-set by rebasing it off the correct
branch or close this PR.
---
-
To unsubscribe, e
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/66
@xiaohu-zhang Why would you want to do that? Please re-apply your changes
on top of master either by using `git rebase master` or manually
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/66
@xiaohu-zhang No problem. I'll pull in your changes and commit them to a
separate branch for review
---
---
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
@xiaohu-zhang This is a large chunk of code that comes directly from
another project. The code is ASLv2 licensed and based on published academic
research. I personally do not see a problem
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
@xiaohu-zhang This is a much bigger change that I have initially
anticipated. It will take me a while to absorb it. First off, I do not think
HttpCore should expose any of those classes in
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/105
The build was failing due to conflicts with Maven Surefire plugin and
Mockito.
---
-
To unsubscribe, e-mail: dev
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/68#discussion_r201268240
--- Diff:
httpcore5-testing/src/main/java/org/apache/hc/core5/testing/nio/IOReactorExecutor.java
---
@@ -85,7 +85,10 @@ public void execute(final
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/68#discussion_r201268536
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/AsyncServer.java
---
@@ -73,8 +73,12 @@ public AsyncServer
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/68
@xiaohu-zhang If you anticipate few connections and want fewer threads you
really _should_ configure fewer workers. Overall, I think this change-set
causes more problems than it solves
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/68
@xiaohu-zhang Why? The I/O reactor distributes sessions across all
available workers equally. If you have n worker threads, all of them will get
started after n connections
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/106
Committed with some changes as 0c0e9c7b7cd9261e8155beac13446b526df36d6b.
Please review and close.
---
-
To
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
@xiaohu-zhang I have spent more time looking at the proposed change-set.
1. Do I understand it correctly that with this patch all
`IOEventHandler#timeout` events will be executed by a
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
1. How come? That basically means that a read or write event can get
triggered by an I/O reactor thread concurrently with a timeout event triggered
by the time-wheel thread making it
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/69
@xiaohu-zhang Committed as e6f3d649c3956422a8e62a61fec9feb922a056fc with
changes. Please review and close.
---
-
To
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/70#discussion_r202546439
--- Diff:
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/ClientHttp2StreamMultiplexer.java
---
@@ -83,10 +83,15 @@ public
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/70#discussion_r202546466
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/HttpCoreContext.java
---
@@ -155,4 +162,10 @@ public HttpResponse getResponse
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/70#discussion_r202547759
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/http/nio/AsyncPushConsumer.java ---
@@ -40,7 +41,7 @@
*/
public interface
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/70#discussion_r202602635
--- Diff:
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/ClientHttp2StreamMultiplexer.java
---
@@ -88,9 +88,8 @@ Http2StreamHandler
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
> Here's another alternative. What if rather than registering the
AsyncPushConsumers on the HttpClient you could pass a AsyncPushConsumer when
making the request:
@ato
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
@ato Please let me know if you intend to continue working on this change. I
want to avoid duplicating your efforts
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/68
@xiaohu-zhang Please close this PR.
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
@ato Committed as 4ddfdbf6504fd1924373bab1c2a5b7b2879183e2. Please review
and close.
---
-
To unsubscribe, e-mail: dev
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
> Yes, I still want this. It sounds like you might want to make some
progress on this yourself though.
Not necessarily. As long as someone is looking into it and can happily s
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
@ato These are the API changes I would like to propose
45c537b84aae7ca7043d1591f74e9e203532562e
---
-
To unsubscribe, e
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
> If the user calls client. execute() with a push consumer it would
override any registered via client.register() right?
Yes, it wo
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/71#discussion_r203660447
--- Diff:
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractHttp2StreamMultiplexer.java
---
@@ -610,7 +612,7 @@ private void
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/71
@ato Are you still interested in contributing this feature or shall I take
over?
---
-
To unsubscribe, e-mail: dev
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/71
@ato
b66198e2de091195232eea96ea3593d2383bcab7#diff-253296d841a758a2fae53c7c42ebb670
does not feel very elegant but it gets it done. Could you please have a look if
that is what you want? I
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/71
@ato Committed to master as 36ef4aa747e6a9a0b00cc93eb3c5482f62e6ba8b
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/72#discussion_r207833571
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/reactor/DefaultConnectingIOReactor.java
---
@@ -119,28 +115,13 @@ public IOReactorStatus
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/72#discussion_r207833195
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/AsyncRequester.java
---
@@ -132,4 +119,8 @@ public void close() throws
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/72#discussion_r207833056
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/AsyncRequester.java
---
@@ -27,12 +27,6 @@
package
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/72
@clevertension Committed with small changes as
2a14ba30fa155c75180b661976aeada583b6b816. Please review and close this PR
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/72
@clevertension Please review and close.
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/73
@clevertension I think the parent project would be a better place for it.
This way the plugin would need to be configured in each and every individual
project.
https://github.com
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/73
@clevertension Fixed in HC parent. Please review and close this PR.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/109
@kirill-usov Kirill, do you still want me to merge this PR? Why is it
closed?
---
-
To unsubscribe, e-mail: dev
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/109
@kirill-usov The plan is to release 5.0b3 by the end of the month provided
everything goes well.
---
-
To
Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/74#discussion_r212394256
--- Diff:
httpcore5-reactive/src/main/java/org/apache/hc/core5/reactive/ReactiveResponseConsumer.java
---
@@ -0,0 +1,176
1 - 100 of 322 matches
Mail list logo
