[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-27 Thread GitBox
michael-o commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r883701230 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/HttpRFC7578Multipart.java: ## @@ -129,7 +128,7 @@ public byte[] encode(final byte[] by

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-27 Thread GitBox
michael-o commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r883702141 ## httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java: ## @@ -0,0 +1,164 @@ +/* + * ==

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-26 Thread GitBox
michael-o commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r882932243 ## httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java: ## @@ -30,39 +30,41 @@ import org.apache.hc.core5.annotation.Internal; -im

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-24 Thread GitBox
michael-o commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r880555943 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/HttpRFC7578Multipart.java: ## @@ -129,7 +128,7 @@ public byte[] encode(final byte[] by

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-24 Thread GitBox
michael-o commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r880450009 ## httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java: ## @@ -0,0 +1,223 @@ +/* + * ==

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-24 Thread GitBox
michael-o commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r880387556 ## httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/HttpRFC7578Multipart.java: ## @@ -129,7 +128,7 @@ public byte[] encode(final byte[] by