[GitHub] [httpcomponents-client] timtebeek commented on pull request #327: HTTPCLIENT-2186 - Migrate Test to Unit 5.

2021-11-21 Thread GitBox
timtebeek commented on pull request #327: URL: https://github.com/apache/httpcomponents-client/pull/327#issuecomment-974708950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [httpcomponents-client] timtebeek commented on pull request #327: HTTPCLIENT-2186 - Migrate Test to Unit 5.

2021-11-20 Thread GitBox
timtebeek commented on pull request #327: URL: https://github.com/apache/httpcomponents-client/pull/327#issuecomment-974721351 Oh wow yes it's quite a bit more involved; looked into it just now, but the whole hierarchy down from

[GitHub] [httpcomponents-client] timtebeek commented on pull request #327: HTTPCLIENT-2186 - Migrate Test to Unit 5.

2021-11-20 Thread GitBox
timtebeek commented on pull request #327: URL: https://github.com/apache/httpcomponents-client/pull/327#issuecomment-974708950 Noticed you're using `@EnableRuleMigrationSupport` to retain `@RunWith(Parameterized.class)`. Are you aware of [this automated JUnit Jupiter migration for