[GitHub] [httpcomponents-core] ok2c commented on pull request #332: Do not explicitly declare runtime exceptions.

2021-11-21 Thread GitBox
ok2c commented on pull request #332: URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974627983 I can and I do because I find explicit declaration of exceptions more useful than javadocs. The above statement from Oracle is silly. -- This is an automated message

[GitHub] [httpcomponents-core] ok2c commented on pull request #332: Do not explicitly declare runtime exceptions.

2021-11-20 Thread GitBox
ok2c commented on pull request #332: URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974627983 I can and I do because I find explicit declaration of exceptions more useful than javadocs. The above statement from Oracle is silly. -- This is an automated message

[GitHub] [httpcomponents-core] ok2c commented on pull request #332: Do not explicitly declare runtime exceptions.

2021-11-19 Thread GitBox
ok2c commented on pull request #332: URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974522841 > Joshua Bloch, Effective Java Did he, really? I am quite sure you wound not mind providing a quote. -- This is an automated message from the Apache Git

[GitHub] [httpcomponents-core] ok2c commented on pull request #332: Do not explicitly declare runtime exceptions.

2021-11-19 Thread GitBox
ok2c commented on pull request #332: URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974501731 > Is just a good practice. @arturobernalg @michael-o Who said that? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [httpcomponents-core] ok2c commented on pull request #332: Do not explicitly declare runtime exceptions.

2021-11-19 Thread GitBox
ok2c commented on pull request #332: URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-973989457 @arturobernalg I do not find this change-set useful. What does it improve exactly? -- This is an automated message from the Apache Git Service. To respond to the