[GitHub] httpclient pull request #74: WIP: OpenTracing integration

2017-05-12 Thread ok2c
Github user ok2c commented on a diff in the pull request: https://github.com/apache/httpclient/pull/74#discussion_r116229419 --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/TracingAsyncExec.java --- @@ -0,0 +1,80 @@ +package org.apache.hc.client5.http

[GitHub] httpclient pull request #74: WIP: OpenTracing integration

2017-05-12 Thread pavolloffay
Github user pavolloffay commented on a diff in the pull request: https://github.com/apache/httpclient/pull/74#discussion_r116227875 --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/TracingAsyncExec.java --- @@ -0,0 +1,80 @@ +package org.apache.hc.clien

[GitHub] httpclient pull request #74: WIP: OpenTracing integration

2017-05-12 Thread ok2c
Github user ok2c commented on a diff in the pull request: https://github.com/apache/httpclient/pull/74#discussion_r116219416 --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/TracingAsyncExec.java --- @@ -0,0 +1,80 @@ +package org.apache.hc.client5.http

[GitHub] httpclient pull request #74: WIP: OpenTracing integration

2017-05-12 Thread pavolloffay
Github user pavolloffay commented on a diff in the pull request: https://github.com/apache/httpclient/pull/74#discussion_r116216114 --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/TracingAsyncExec.java --- @@ -0,0 +1,80 @@ +package org.apache.hc.clien

[GitHub] httpclient pull request #74: WIP: OpenTracing integration

2017-04-28 Thread adriancole
Github user adriancole commented on a diff in the pull request: https://github.com/apache/httpclient/pull/74#discussion_r114044778 --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/sync/HttpClientBuilder.java --- @@ -888,6 +898,10 @@ public void close() throws IO

[GitHub] httpclient pull request #74: WIP: OpenTracing integration

2017-04-28 Thread pavolloffay
GitHub user pavolloffay opened a pull request: https://github.com/apache/httpclient/pull/74 WIP: OpenTracing integration OpenTracing integration. Tracing `ClientExecChain` has to be registered as the last one. It should wrap all the client invocation. There will be