Re: [PR] Add validation to prevent both 'username' and 'username*' in DigestScheme headers. [httpcomponents-client]

2023-12-08 Thread via GitHub
arturobernalg closed pull request #510: Add validation to prevent both 'username' and 'username*' in DigestScheme headers. URL: https://github.com/apache/httpcomponents-client/pull/510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Add validation to prevent both 'username' and 'username*' in DigestScheme headers. [httpcomponents-client]

2023-12-08 Thread via GitHub
ok2c commented on code in PR #510: URL: https://github.com/apache/httpcomponents-client/pull/510#discussion_r1420232191 ## httpclient5/src/test/java/org/apache/hc/client5/http/impl/auth/TestDigestScheme.java: ## @@ -746,4 +746,25 @@ public void testSerialization() throws Except

Re: [PR] Add validation to prevent both 'username' and 'username*' in DigestScheme headers. [httpcomponents-client]

2023-12-07 Thread via GitHub
arturobernalg commented on code in PR #510: URL: https://github.com/apache/httpcomponents-client/pull/510#discussion_r1419555226 ## httpclient5/src/test/java/org/apache/hc/client5/http/impl/auth/TestDigestScheme.java: ## @@ -746,4 +746,25 @@ public void testSerialization() thro

Re: [PR] Add validation to prevent both 'username' and 'username*' in DigestScheme headers. [httpcomponents-client]

2023-12-03 Thread via GitHub
ok2c commented on code in PR #510: URL: https://github.com/apache/httpcomponents-client/pull/510#discussion_r1413038237 ## httpclient5/src/test/java/org/apache/hc/client5/http/impl/auth/TestDigestScheme.java: ## @@ -746,4 +746,25 @@ public void testSerialization() throws Except

[PR] Add validation to prevent both 'username' and 'username*' in DigestScheme headers. [httpcomponents-client]

2023-11-24 Thread via GitHub
arturobernalg opened a new pull request, #510: URL: https://github.com/apache/httpcomponents-client/pull/510 This commit introduces a new validation check in the ´DigestScheme ´class to ensure that both 'username' and 'username*' are not present simultaneously in the same authentication