Re: [PR] HTTPCLIENT-2318 - Enhance PoolingHttpClientConnectionManager with isShutdown State Check. [httpcomponents-client]

2024-02-23 Thread via GitHub
ok2c merged PR #549: URL: https://github.com/apache/httpcomponents-client/pull/549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HTTPCLIENT-2318 - Enhance PoolingHttpClientConnectionManager with isShutdown State Check. [httpcomponents-client]

2024-02-22 Thread via GitHub
ok2c commented on code in PR #549: URL: https://github.com/apache/httpcomponents-client/pull/549#discussion_r1500300831 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java: ## @@ -796,4 +807,16 @@ public EndpointInfo

Re: [PR] HTTPCLIENT-2318 - Enhance PoolingHttpClientConnectionManager with isShutdown State Check. [httpcomponents-client]

2024-02-22 Thread via GitHub
arturobernalg commented on code in PR #549: URL: https://github.com/apache/httpcomponents-client/pull/549#discussion_r1499524784 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java: ## @@ -796,4 +807,16 @@ public EndpointInfo

Re: [PR] HTTPCLIENT-2318 - Enhance PoolingHttpClientConnectionManager with isShutdown State Check. [httpcomponents-client]

2024-02-22 Thread via GitHub
ok2c commented on code in PR #549: URL: https://github.com/apache/httpcomponents-client/pull/549#discussion_r1498831000 ## httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java: ## @@ -796,4 +807,16 @@ public EndpointInfo

Re: [PR] HTTPCLIENT-2318 - Enhance PoolingHttpClientConnectionManager with isShutdown State Check. [httpcomponents-client]

2024-02-21 Thread via GitHub
arturobernalg commented on PR #549: URL: https://github.com/apache/httpcomponents-client/pull/549#issuecomment-1957840984 > conn manager implementations are consistent @ok2c , absolutely. Thank you for pointing that out. -- This is an automated message from the Apache Git Service.

Re: [PR] HTTPCLIENT-2318 - Enhance PoolingHttpClientConnectionManager with isShutdown State Check. [httpcomponents-client]

2024-02-21 Thread via GitHub
ok2c commented on PR #549: URL: https://github.com/apache/httpcomponents-client/pull/549#issuecomment-1956110672 @arturobernalg Curiously enough I found this commit 6ba9b4ac you contributed in the past. Could you please make sure all 3 conn manager implementations are consistent? --

[PR] HTTPCLIENT-2318 - Enhance PoolingHttpClientConnectionManager with isShutdown State Check. [httpcomponents-client]

2024-02-20 Thread via GitHub
arturobernalg opened a new pull request, #549: URL: https://github.com/apache/httpcomponents-client/pull/549 This PR addresses the issue described in [HTTPCLIENT-2318](https://issues.apache.org/jira/browse/HTTPCLIENT-2318) by enhancing the `PoolingHttpClientConnectionManager`. It