Re: [jira] Commented: (HTTPCLIENT-735) allow unsetting of DEFAULT_PROXY and FORCED_ROUTE parameters in the client stack

2008-02-07 Thread Roland Weber
Hi Oleg, >>> Why not make NO_HOST a little prettier? I've changed it to "no-host://127.0.0.255:0" which is a valid HttpHost instance but still unlikely to collide with any real host. >> And can we rely >> on ourselves not adding empty string checks to the >> HttpHost constructor? > > I believe

Re: [jira] Commented: (HTTPCLIENT-735) allow unsetting of DEFAULT_PROXY and FORCED_ROUTE parameters in the client stack

2008-02-07 Thread Oleg Kalnichevski
On Wed, 2008-02-06 at 23:18 +0100, Roland Weber wrote: > Hi Oleg, > > > Why not make NO_HOST a little prettier? > > > > public static final HttpHost NO_HOST = new HttpHost("", -1, ""); > > I chose an IP address for the host to make sure that > there will be no DNS lookup (though there might st

Re: [jira] Commented: (HTTPCLIENT-735) allow unsetting of DEFAULT_PROXY and FORCED_ROUTE parameters in the client stack

2008-02-06 Thread Roland Weber
Hi Oleg, > Why not make NO_HOST a little prettier? > > public static final HttpHost NO_HOST = new HttpHost("", -1, ""); I chose an IP address for the host to make sure that there will be no DNS lookup (though there might still be a reverse lookup). Can we rely on an exception being triggered fo

[jira] Commented: (HTTPCLIENT-735) allow unsetting of DEFAULT_PROXY and FORCED_ROUTE parameters in the client stack

2008-02-06 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566363#action_12566363 ] Oleg Kalnichevski commented on HTTPCLIENT-735: -- Roland Why not make NO_HO