Re: Allow access to default HttpParams

2010-12-14 Thread sebb
On 14 December 2010 13:27, Oleg Kalnichevski wrote: >> > >> > Makes sense to me. >> >> How about adding entrySet() to the HttpParams interface? > > We can't do that > >> Without that, DefaultedHttpParams has to assume that its local >> HttpParams extends AbstractHttpParams. >> >> Changing the inte

Re: Allow access to default HttpParams

2010-12-14 Thread Oleg Kalnichevski
> > > > Makes sense to me. > > How about adding entrySet() to the HttpParams interface? We can't do that > Without that, DefaultedHttpParams has to assume that its local > HttpParams extends AbstractHttpParams. > > Changing the interface would of course break any code that implements > the Http

Re: Allow access to default HttpParams

2010-12-14 Thread sebb
On 14 December 2010 09:03, Oleg Kalnichevski wrote: > On Tue, 2010-12-14 at 01:41 +, sebb wrote: >> On 13 December 2010 20:32, Oleg Kalnichevski wrote: >> > On Mon, 2010-12-13 at 16:35 +, sebb wrote: > > ... > >> > Feel free to introduce an iterator to BasicHttpParams / SyncHttpParams >>

Re: Allow access to default HttpParams

2010-12-14 Thread Oleg Kalnichevski
On Tue, 2010-12-14 at 01:41 +, sebb wrote: > On 13 December 2010 20:32, Oleg Kalnichevski wrote: > > On Mon, 2010-12-13 at 16:35 +, sebb wrote: ... > > Feel free to introduce an iterator to BasicHttpParams / SyncHttpParams > > classes. > > I added entrySet() to BasicHttpParams, and adde

Re: Allow access to default HttpParams

2010-12-13 Thread sebb
On 13 December 2010 20:32, Oleg Kalnichevski wrote: > On Mon, 2010-12-13 at 16:35 +, sebb wrote: > >> == >> >> I think there should be a public method which gives access to a >> read-only copy of the parameters. >> This could either be done by: >> * changing BasicHttpParams#copyParams(HttpPara

Re: Allow access to default HttpParams

2010-12-13 Thread Oleg Kalnichevski
On Mon, 2010-12-13 at 16:35 +, sebb wrote: > == > > I think there should be a public method which gives access to a > read-only copy of the parameters. > This could either be done by: > * changing BasicHttpParams#copyParams(HttpParams target) to be public, > in which case we probably need to

Re: Allow access to default HttpParams

2010-12-13 Thread sebb
On 13 December 2010 15:08, Oleg Kalnichevski wrote: > On Mon, 2010-12-13 at 11:20 +, sebb wrote: >> For HC 3.1, JMeter supports a configuration file which can be used to >> set up global defaults. >> >> There is no concept of global defaults in HC 4.x, but one can >> initialise HttpClient with

Re: Allow access to default HttpParams

2010-12-13 Thread Oleg Kalnichevski
On Mon, 2010-12-13 at 11:20 +, sebb wrote: > For HC 3.1, JMeter supports a configuration file which can be used to > set up global defaults. > > There is no concept of global defaults in HC 4.x, but one can > initialise HttpClient with a DefaultedHttpParams to get similar > functionality. > >

Allow access to default HttpParams

2010-12-13 Thread sebb
For HC 3.1, JMeter supports a configuration file which can be used to set up global defaults. There is no concept of global defaults in HC 4.x, but one can initialise HttpClient with a DefaultedHttpParams to get similar functionality. The method DefaultHttpClient.createHttpParams() creates a defa