Bug in TimeValue

2019-12-15 Thread Michael Osipov
Gary, while working on HTTPCLIENT-2036 I have found a bug in TimeValue#equals() method. It does not properly scale the value if time unit prefixes are different. It says that "1000 ms != 1 s" which is wrong mathematically. You have to multiply with the smallest prefix not to lose

Re: Bug in TimeValue

2019-12-15 Thread Gary Gregory
Looking... On Sun, Dec 15, 2019 at 11:11 AM Michael Osipov wrote: > Gary, > > while working on HTTPCLIENT-2036 I have found a bug in > TimeValue#equals() method. It does not properly scale the value if time > unit prefixes are different. It says that "1000 ms != 1

Re: Bug in TimeValue

2019-12-15 Thread Gary Gregory
Gary Gregory wrote: > Looking... > > On Sun, Dec 15, 2019 at 11:11 AM Michael Osipov > wrote: > >> Gary, >> >> while working on HTTPCLIENT-2036 I have found a bug in >> TimeValue#equals() method. It does not properly scale the value if time >> unit prefi