Re: JUnit 5 upgrade rant (contains obscene language)

2022-10-26 Thread Oleg Kalnichevski
It turned out to be a genuine bug in HTTP/1.1 protocol handling code that can be triggered if a body of the preceding message and a head of the following message are delivered in a single IP frame. I have no explanation as to why the bug does not seem to be affecting test cases in the 5.1 branc

Re: JUnit 5 upgrade rant (contains obscene language)

2022-10-24 Thread Kalnichevski Oleg
On 10/23/2022 10:51 PM, Ryan Schmitt wrote: If you'd like, I could run `git-bisect` to figure out where the tests broke; I'll just need to know which tests broke and how to run them. Much appreciated, Ryan. The tests tend to fail intermittently and there is no guarantee one can reliably catch

Re: JUnit 5 upgrade rant (contains obscene language)

2022-10-23 Thread Ryan Schmitt
If you'd like, I could run `git-bisect` to figure out where the tests broke; I'll just need to know which tests broke and how to run them. On Sat, Oct 22, 2022 at 8:14 AM Oleg Kalnichevski wrote: > The JUnit 5 upgrade was a cluster. > > The original contributor ported some of the easy test case

Re: JUnit 5 upgrade rant (contains obscene language)

2022-10-23 Thread Ryan Schmitt
assertThrows is available in JUnit 4.13. On Sun, Oct 23, 2022 at 4:11 AM Gary Gregory wrote: > Version 5 has some drawbacks but on the positive side, APIs like > assertThrows are very useful. > > Gary > > On Sun, Oct 23, 2022, 04:31 Michael Osipov wrote: > > > Am 2022-10-22 um 17:14 schrieb Ole

Re: JUnit 5 upgrade rant (contains obscene language)

2022-10-23 Thread Gary Gregory
Version 5 has some drawbacks but on the positive side, APIs like assertThrows are very useful. Gary On Sun, Oct 23, 2022, 04:31 Michael Osipov wrote: > Am 2022-10-22 um 17:14 schrieb Oleg Kalnichevski: > > The JUnit 5 upgrade was a cluster. > > > > The original contributor ported some of the e

Re: JUnit 5 upgrade rant (contains obscene language)

2022-10-23 Thread Michael Osipov
Am 2022-10-22 um 17:14 schrieb Oleg Kalnichevski: The JUnit 5 upgrade was a cluster. The original contributor ported some of the easy test cases that did not have a complex resource setup and left most complex and most important protocol and integration tests still partially using JUnit 4 featu

JUnit 5 upgrade rant (contains obscene language)

2022-10-22 Thread Oleg Kalnichevski
The JUnit 5 upgrade was a cluster. The original contributor ported some of the easy test cases that did not have a complex resource setup and left most complex and most important protocol and integration tests still partially using JUnit 4 features through the JUnit 5 migration layer. I cannot b